url: refactor to use more primordials #36316
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aduh95
added
needs-benchmark-ci
mscdex
previously requested changes
Nov 30, 2020
There was a problem hiding this comment.
There are quite a few performance regressions with these changes:
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='encodefake' *** -14.06 % ±3.44% ±4.62% ±6.12%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='encodemany' *** -5.30 % ±2.01% ±2.67% ±3.48%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='manypairs' *** -33.05 % ±2.70% ±3.63% ±4.80%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multicharsep' *** -15.20 % ±2.71% ±3.64% ±4.80%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multivalue' *** -17.42 % ±4.68% ±6.31% ±8.36%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='multivaluemany' *** -21.22 % ±1.89% ±2.54% ±3.35%
url/legacy-vs-whatwg-url-searchparams-parse.js n=1000000 method='whatwg' searchParam='noencode' *** -23.02 % ±5.13% ±6.91% ±9.17%
url/url-searchparams-iteration.js n=1000000 loopMethod='forEach' *** -48.89 % ±1.47% ±1.97% ±2.60%
url/url-searchparams-read.js n=20000000 param='one' accessMethod='getAll' *** -3.59 % ±1.19% ±1.58% ±2.06%
url/url-searchparams-read.js n=20000000 param='three' accessMethod='getAll' *** -19.54 % ±2.22% ±2.95% ±3.85%
url/url-searchparams-read.js n=20000000 param='two' accessMethod='getAll' *** -6.40 % ±1.75% ±2.33% ±3.04%
|
@mscdex I've removed the changes causing significant perf regression, PTAL Benchmark CI: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/795/console Results |
aduh95
added
review wanted
github-actions
bot
removed
the
request-ci
Trott
approved these changes
Dec 25, 2020
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/36316 ✔ Done loading data for nodejs/node/pull/36316 ----------------------------------- PR info ------------------------------------ Title url: refactor to use more primordials (#36316) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch aduh95:url-primordials -> nodejs:master Labels review wanted, whatwg-url Commits 2 - url: refactor to use more primordials - fixup! url: refactor to use more primordials Committers 1 - Antoine du Hamel PR-URL: https://github.com/nodejs/node/pull/36316 Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/36316 Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ✖ Last GitHub CI failed ℹ Last Benchmark CI on 2020-12-24T10:06:18Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/795/console ℹ Last Full PR CI on 2020-12-24T15:20:35Z: https://ci.nodejs.org/job/node-test-pull-request/35064/ - Querying data for job/node-test-pull-request/35064/ ✔ Build data downloaded ✔ Last Jenkins CI successful ℹ This PR was created on Sun, 29 Nov 2020 17:54:03 GMT ✔ Approvals: 1 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/36316#pullrequestreview-558821900 -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/444394775 |
PR-URL: nodejs#36316 Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95
force-pushed
the
url-primordials
branch
from
77a6dd3
to
5d28edc
Compare
|
Landed in 5d28edc |
danielleadams
pushed a commit
that referenced
this pull request
Jan 12, 2021
PR-URL: #36316 Reviewed-By: Rich Trott <rtrott@gmail.com>
Merged
targos
pushed a commit
that referenced
this pull request
May 25, 2021
PR-URL: #36316 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 5, 2021
PR-URL: #36316 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jun 11, 2021
PR-URL: #36316 Reviewed-By: Rich Trott <rtrott@gmail.com>
targos
removed
the
commit-queue-failed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes