Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v15.x] http: do not loop over prototype in Agent #36410

Closed
wants to merge 1 commit into from
Closed

[v15.x] http: do not loop over prototype in Agent #36410

wants to merge 1 commit into from

Conversation

targos
Copy link
Member

@targos targos commented Dec 6, 2020

Fixes: #36364

This is a semver-patch version of #36409

@nodejs-github-bot nodejs-github-bot added the http Issues or PRs related to the http subsystem. label Dec 6, 2020
@targos targos changed the title http: do not loop over prototype in Agent [v15.x] http: do not loop over prototype in Agent Dec 6, 2020
@targos targos added lts-watch-v12.x request-ci Add this label to start a Jenkins CI on a PR. labels Dec 6, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 6, 2020
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/34796/

rickyes
rickyes approved these changes Dec 8, 2020
View reviewed changes
Copy link
Contributor

@rickyes rickyes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@targos targos mentioned this pull request Dec 9, 2020
Closed
targos added a commit that referenced this pull request Dec 13, 2020
@targos
http: do not loop over prototype in Agent
9852ebc 
Fixes: #36364

PR-URL: #36410
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@targos
Copy link
Member Author

targos commented Dec 13, 2020

Landed in 9852ebc

@targos targos closed this Dec 13, 2020
@targos targos deleted the fix-36364-v15 branch December 13, 2020 21:18
@targos targos mentioned this pull request Dec 22, 2020
Merged
@seven-deuce seven-deuce mentioned this pull request Feb 3, 2021
Closed
BethGriggs pushed a commit that referenced this pull request Feb 8, 2021
@targos @BethGriggs
http: do not loop over prototype in Agent
017eed6 
Fixes: #36364

PR-URL: #36410
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Feb 8, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Feb 8, 2021
@targos @ruyadorno
http: do not loop over prototype in Agent
9a9cf1e 
Fixes: #36364

PR-URL: #36410
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Feb 9, 2021
Merged
ruyadorno pushed a commit that referenced this pull request Feb 10, 2021
@targos @ruyadorno
http: do not loop over prototype in Agent
cd9a810 
Fixes: #36364

PR-URL: #36410
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: Ricky Zhou <0x19951125@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@rickyes rickyes rickyes approved these changes

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@targos @nodejs-github-bot @Flarna @rickyes @richardlau