Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to use optional chaining in internal/options.js #36939

Merged
merged 0 commits into from Jan 24, 2021
Merged

lib: refactor to use optional chaining in internal/options.js #36939

merged 0 commits into from Jan 24, 2021

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
@aduh95
Copy link
Contributor

aduh95 commented Jan 15, 2021 •
edited

I'd rather have #36652 landed TBH (or closed if we don't want to do it).

Removing Author ready label as there is no running CI – and a "concurrent" PR.

@aduh95 aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 15, 2021
@RaisinTen
Copy link
Contributor Author

@aduh95 sure, no problem! :)

aduh95
aduh95 approved these changes Jan 19, 2021
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if #36989 lands

@aduh95 aduh95 added blocked PRs that are blocked by other issues or PRs. author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed blocked PRs that are blocked by other issues or PRs. labels Jan 19, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35691/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35696/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/35704/

@Trott Trott closed this Jan 24, 2021
@Trott Trott force-pushed the lib/refactor-to-use-optional-chaining-in-internal/options.js branch from 758c8cb to 85e6089 Compare January 24, 2021 16:20
@Trott Trott merged commit 85e6089 into nodejs:master Jan 24, 2021
@Trott
Copy link
Member

Trott commented Jan 24, 2021

Landed in 85e6089

@RaisinTen RaisinTen deleted the lib/refactor-to-use-optional-chaining-in-internal/options.js branch January 24, 2021 16:24
targos pushed a commit that referenced this pull request Feb 2, 2021
@RaisinTen @targos
lib: refactor to use optional chaining in internal/options.js
4a1fc42 
PR-URL: #36939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Feb 2, 2021
Merged
targos pushed a commit that referenced this pull request May 25, 2021
@RaisinTen @targos
lib: refactor to use optional chaining in internal/options.js
f3adc62 
PR-URL: #36939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@RaisinTen @targos
lib: refactor to use optional chaining in internal/options.js
3fb2c08 
PR-URL: #36939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@RaisinTen @targos
lib: refactor to use optional chaining in internal/options.js
4dc12f5 
PR-URL: #36939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@RaisinTen @targos
lib: refactor to use optional chaining in internal/options.js
47ed512 
PR-URL: #36939
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@RaisinTen @aduh95 @nodejs-github-bot @Trott @jasnell