From 3bd64e2341fd2c085a5841b5e0607fce0217ce9a Mon Sep 17 00:00:00 2001 From: Voltrex <62040526+VoltrexMaster@users.noreply.github.com> Date: Thu, 8 Apr 2021 06:43:59 +0430 Subject: [PATCH 1/3] doc: add link to V8 Added the link redirecting to the V8 engine github repository just like libuv. --- doc/api/addons.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/doc/api/addons.md b/doc/api/addons.md index 63bc1ec86ce3b1..81f03de4b99f0b 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -16,7 +16,7 @@ Node-API. When not using Node-API, implementing addons is complicated, involving knowledge of several components and APIs: -* V8: the C++ library Node.js uses to provide the +* [V8][]: the C++ library Node.js uses to provide the JavaScript implementation. V8 provides the mechanisms for creating objects, calling functions, etc. V8's API is documented mostly in the `v8.h` header file (`deps/v8/include/v8.h` in the Node.js source @@ -1372,4 +1372,5 @@ console.log(result); [libuv]: https://github.com/libuv/libuv [node-gyp]: https://github.com/nodejs/node-gyp [require]: modules.md#modules_require_id +[V8]: https://github.com/v8/v8 [v8-docs]: https://v8docs.nodesource.com/ From df3694232a6824e41cfef5ceee3651f574f08c8f Mon Sep 17 00:00:00 2001 From: Voltrex <62040526+VoltrexMaster@users.noreply.github.com> Date: Thu, 8 Apr 2021 06:49:43 +0430 Subject: [PATCH 2/3] Fix link order V8 should be above Worker. --- doc/api/addons.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/addons.md b/doc/api/addons.md index 81f03de4b99f0b..5adcfcb5b3f545 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -1364,6 +1364,7 @@ console.log(result); [Embedder's Guide]: https://github.com/v8/v8/wiki/Embedder's%20Guide [Linking to libraries included with Node.js]: #addons_linking_to_libraries_included_with_node_js [Native Abstractions for Node.js]: https://github.com/nodejs/nan +[V8]: https://github.com/v8/v8 [`Worker`]: worker_threads.md#worker_threads_class_worker [bindings]: https://github.com/TooTallNate/node-bindings [download]: https://github.com/nodejs/node-addon-examples @@ -1372,5 +1373,4 @@ console.log(result); [libuv]: https://github.com/libuv/libuv [node-gyp]: https://github.com/nodejs/node-gyp [require]: modules.md#modules_require_id -[V8]: https://github.com/v8/v8 [v8-docs]: https://v8docs.nodesource.com/ From 0c108a07d5df47399fddfaba92d0241303022307 Mon Sep 17 00:00:00 2001 From: Voltrex <62040526+VoltrexMaster@users.noreply.github.com> Date: Thu, 8 Apr 2021 19:49:25 +0430 Subject: [PATCH 3/3] Refer to the main V8 domain V8 redirect URL should redirect to the google source original domain instead of the mirror. --- doc/api/addons.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/doc/api/addons.md b/doc/api/addons.md index 5adcfcb5b3f545..b17e86febee671 100644 --- a/doc/api/addons.md +++ b/doc/api/addons.md @@ -1364,7 +1364,7 @@ console.log(result); [Embedder's Guide]: https://github.com/v8/v8/wiki/Embedder's%20Guide [Linking to libraries included with Node.js]: #addons_linking_to_libraries_included_with_node_js [Native Abstractions for Node.js]: https://github.com/nodejs/nan -[V8]: https://github.com/v8/v8 +[V8]: https://v8.dev/ [`Worker`]: worker_threads.md#worker_threads_class_worker [bindings]: https://github.com/TooTallNate/node-bindings [download]: https://github.com/nodejs/node-addon-examples