Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

benchmark: use process.hrtime.bigint() #38369

Closed
wants to merge 1 commit into from
Closed

benchmark: use process.hrtime.bigint() #38369

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 23, 2021 •
edited

Using BigInt may result in better precision than the legacy process.hrtime() we are currently using (as long as the run completes in less than 100 days :)).

@nodejs-github-bot nodejs-github-bot added the benchmark Issues and PRs related to the benchmark subsystem. label Apr 23, 2021
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 23, 2021
@jasnell
Copy link
Member

jasnell commented Apr 26, 2021

Landed in 4e9ad20

@jasnell jasnell closed this Apr 26, 2021
jasnell pushed a commit that referenced this pull request Apr 26, 2021
@aduh95 @jasnell
benchmark: use process.hrtime.bigint()
4e9ad20 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the benchmark-bigint branch April 26, 2021 21:38
targos pushed a commit that referenced this pull request Apr 29, 2021
@aduh95 @targos
benchmark: use process.hrtime.bigint()
ba15b20 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
aduh95 added a commit to aduh95/node that referenced this pull request May 20, 2021
@aduh95
benchmark: fix http elapsed time
18a0c63 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: nodejs#38369
@aduh95 aduh95 mentioned this pull request May 20, 2021
Closed
Lxxyx pushed a commit to Lxxyx/node that referenced this pull request May 23, 2021
@aduh95 @Lxxyx
benchmark: fix http elapsed time
ba84524 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: nodejs#38369

PR-URL: nodejs#38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request May 30, 2021
@aduh95 @targos
benchmark: use process.hrtime.bigint()
9f7e0be 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request May 31, 2021
@aduh95 @danielleadams
benchmark: fix http elapsed time
7a9d0fd 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: #38369

PR-URL: #38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
benchmark: use process.hrtime.bigint()
557fdfe 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@aduh95 @targos
benchmark: use process.hrtime.bigint()
d62491e 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@aduh95 @targos
benchmark: use process.hrtime.bigint()
9e4c1f2 
PR-URL: #38369
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 16, 2021
@aduh95 @richardlau
benchmark: fix http elapsed time
ea832d1 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: #38369

PR-URL: #38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 19, 2021
@aduh95 @richardlau
benchmark: fix http elapsed time
18a8834 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: #38369

PR-URL: #38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 20, 2021
@aduh95 @richardlau
benchmark: fix http elapsed time
f9693cf 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: #38369

PR-URL: #38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
benchmark: fix http elapsed time
ecbe054 
Since commit 4e9ad20, elapsed time is expected to be a BigInt
instead of an array.

Refs: nodejs#38369

PR-URL: nodejs#38743
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@benjamingr benjamingr benjamingr approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. benchmark Issues and PRs related to the benchmark subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aduh95 @jasnell @addaleax @benjamingr @nodejs-github-bot