doc: align module resolve algorithm with implementation #38837
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
doc
bl-ue
reviewed
May 29, 2021
|
@nodejs/modules |
guybedford
reviewed
May 29, 2021
Co-authored-by: Jordan Harband <ljharb@gmail.com> Co-authored-by: Christopher Beeson <christopher@bl-ue.com>
ljharb
reviewed
May 31, 2021
Co-authored-by: Jordan Harband <ljharb@gmail.com>
|
It seems that GH action |
|
When will this PR be merged 😂 |
guybedford
approved these changes
Dec 14, 2021
|
Landed in ea977fc |
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
Fixes: nodejs#38128 PR-URL: nodejs#38837 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In docs, it reads like
GLOBAL_FOLDERStakes precedence overnode_module, but in implementation,GLOBAL_FOLDERSis appended to the last of paths to resolve. It should take lowest priority.node/lib/internal/modules/cjs/loader.js
Line 678 in f1cbaea
Fixes: #38128