From 228067ba4bd118130cf6b036ed8d3af464e9dab9 Mon Sep 17 00:00:00 2001
From: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Mon, 6 Sep 2021 20:07:59 +0200
Subject: [PATCH 1/2] fs: add `FileHandle.prototype.arrayBuffer` method

Refs: https://w3c.github.io/FileAPI/#dom-blob-arraybuffer
---
 doc/api/fs.md                                 | 11 +++++++
 lib/internal/fs/promises.js                   |  5 ++++
 ...est-fs-promises-file-handle-arrayBuffer.js | 30 +++++++++++++++++++
 3 files changed, 46 insertions(+)
 create mode 100644 test/parallel/test-fs-promises-file-handle-arrayBuffer.js

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 3be576e175eed5..319c9d840e7001 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -188,6 +188,17 @@ When operating on file handles, the mode cannot be changed from what it was set
 to with [`fsPromises.open()`][]. Therefore, this is equivalent to
 [`filehandle.writeFile()`][].
 
+#### `filehandle.arrayBuffer()`
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+* Returns: {Promise} Fulfills with an {ArrayBuffer} upon success.
+
+Reads the whole file as binary data.
+
 #### `filehandle.chmod(mode)`
 <!-- YAML
 added: v10.0.0
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index e26f1314d155de..a1c36b26ef99a4 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -252,6 +252,11 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {
     return readable;
   }
 
+  async arrayBuffer() {
+    const buffer = await this.readFile();
+    return buffer.buffer;
+  }
+
   [kTransfer]() {
     if (this[kClosePromise] || this[kRefs] > 1) {
       throw lazyDOMException('Cannot transfer FileHandle while in use',
diff --git a/test/parallel/test-fs-promises-file-handle-arrayBuffer.js b/test/parallel/test-fs-promises-file-handle-arrayBuffer.js
new file mode 100644
index 00000000000000..4b7ef0e037894a
--- /dev/null
+++ b/test/parallel/test-fs-promises-file-handle-arrayBuffer.js
@@ -0,0 +1,30 @@
+'use strict';
+
+const common = require('../common');
+
+// The following tests validate FileHandle.prototype.arrayBuffer method.
+
+const fs = require('fs');
+const { open } = fs.promises;
+const path = require('path');
+const tmpdir = require('../common/tmpdir');
+const assert = require('assert');
+const tmpDir = tmpdir.path;
+
+tmpdir.refresh();
+
+(async () => {
+  const data = Buffer.allocUnsafe(100);
+  const filePath = path.resolve(tmpDir, 'arrayBuffer');
+  fs.writeFileSync(filePath, data);
+
+  let fileHandle;
+  try {
+    fileHandle = await open(filePath);
+
+    const fileContent = await fileHandle.arrayBuffer();
+    assert.deepStrictEqual(Buffer.from(fileContent), data);
+  } finally {
+    await fileHandle?.close();
+  }
+})().then(common.mustCall());

From 109bf7e32ea77c85c574e78dedf66ba8c75d62ba Mon Sep 17 00:00:00 2001
From: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date: Mon, 6 Sep 2021 20:08:43 +0200
Subject: [PATCH 2/2] fs: add `FileHandle.prototype.text` method

Refs: https://w3c.github.io/FileAPI/#dom-blob-text
---
 doc/api/fs.md                                 | 11 +++++++
 lib/internal/fs/promises.js                   |  4 +++
 .../test-fs-promises-file-handle-text.js      | 30 +++++++++++++++++++
 3 files changed, 45 insertions(+)
 create mode 100644 test/parallel/test-fs-promises-file-handle-text.js

diff --git a/doc/api/fs.md b/doc/api/fs.md
index 319c9d840e7001..790b6046e034f6 100644
--- a/doc/api/fs.md
+++ b/doc/api/fs.md
@@ -426,6 +426,17 @@ Request that all data for the open file descriptor is flushed to the storage
 device. The specific implementation is operating system and device specific.
 Refer to the POSIX fsync(2) documentation for more detail.
 
+#### `filehandle.text()`
+<!-- YAML
+added: REPLACEME
+-->
+
+> Stability: 1 - Experimental
+
+* Returns: {Promise} Fulfills with a {string} upon success.
+
+Reads the whole file as UTF-8 text.
+
 #### `filehandle.truncate(len)`
 <!-- YAML
 added: v10.0.0
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
index a1c36b26ef99a4..792764ee2fd85c 100644
--- a/lib/internal/fs/promises.js
+++ b/lib/internal/fs/promises.js
@@ -257,6 +257,10 @@ class FileHandle extends EventEmitterMixin(JSTransferable) {
     return buffer.buffer;
   }
 
+  text() {
+    return this.readFile({ encoding: 'utf8' });
+  }
+
   [kTransfer]() {
     if (this[kClosePromise] || this[kRefs] > 1) {
       throw lazyDOMException('Cannot transfer FileHandle while in use',
diff --git a/test/parallel/test-fs-promises-file-handle-text.js b/test/parallel/test-fs-promises-file-handle-text.js
new file mode 100644
index 00000000000000..a1801d47d0debf
--- /dev/null
+++ b/test/parallel/test-fs-promises-file-handle-text.js
@@ -0,0 +1,30 @@
+'use strict';
+
+const common = require('../common');
+
+// The following tests validate FileHandle.prototype.text method.
+
+const fs = require('fs');
+const { open } = fs.promises;
+const path = require('path');
+const tmpdir = require('../common/tmpdir');
+const assert = require('assert');
+const tmpDir = tmpdir.path;
+
+tmpdir.refresh();
+
+(async () => {
+  const data = 'Hello World!';
+  const filePath = path.resolve(tmpDir, 'text');
+  fs.writeFileSync(filePath, data);
+
+  let fileHandle;
+  try {
+    fileHandle = await open(filePath);
+
+    const fileContent = await fileHandle.text();
+    assert.strictEqual(fileContent, data);
+  } finally {
+    await fileHandle?.close();
+  }
+})().then(common.mustCall());