doc: fix CJS-ESM selector in Safari #40135
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lpinca
approved these changes
Sep 17, 2021
targos
reviewed
Sep 17, 2021
wooorm
approved these changes
Sep 17, 2021
aduh95
approved these changes
Sep 17, 2021
aduh95
added
fast-track
|
Fast-track has been requested by @aduh95. Please 👍 to approve. |
targos
approved these changes
Sep 17, 2021
Safari needs a vendor prefix on the appearance of the checkbox. PR-URL: #40135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
aduh95
force-pushed
the
doc-safari-cjs-esm-css
branch
from
ea8c2bb
to
6bfe5a6
Compare
|
Landed in 6bfe5a6. |
This was referenced Sep 18, 2021
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
Safari needs a vendor prefix on the appearance of the checkbox. PR-URL: #40135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Sep 21, 2021
Safari needs a vendor prefix on the appearance of the checkbox. PR-URL: #40135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
This was referenced Sep 22, 2021
aduh95
pushed a commit
to aduh95/node
that referenced
this pull request
Oct 22, 2021
Safari needs a vendor prefix on the appearance of the checkbox. PR-URL: nodejs#40135 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
added
backported-to-v14.x
and removed
author ready
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Safari needs a vendor prefix on the appearance of the checkbox