Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib: refactor to avoid unsafe array iteration #40271

Closed
wants to merge 1 commit into from
Closed

lib: refactor to avoid unsafe array iteration #40271

wants to merge 1 commit into from

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Sep 30, 2021

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Sep 30, 2021
@aduh95 aduh95 mentioned this pull request Sep 30, 2021
Merged
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Sep 30, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Sep 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40115/

@github-actions github-actions bot mentioned this pull request Oct 1, 2021
Open
19 tasks
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 1, 2021 •
edited by aduh95

CI: https://ci.nodejs.org/job/node-test-pull-request/40117/ ✅

This was referenced Oct 2, 2021
Open
Open
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 3, 2021
@github-actions
Copy link
Contributor

github-actions bot commented Oct 3, 2021

Landed in 5ae72b7...e2382d0

@github-actions github-actions bot closed this Oct 3, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 3, 2021
@aduh95 @nodejs-github-bot
lib: refactor to avoid unsafe array iteration
e2382d0 
PR-URL: #40271
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@aduh95 aduh95 deleted the v8-prof-processor-array-iter branch October 3, 2021 09:48
@github-actions github-actions bot mentioned this pull request Oct 4, 2021
Open
22 tasks
targos pushed a commit that referenced this pull request Oct 4, 2021
@aduh95 @targos
lib: refactor to avoid unsafe array iteration
3d5eba8 
PR-URL: #40271
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 4, 2021
Merged
This was referenced Oct 5, 2021
Open
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@benjamingr benjamingr benjamingr approved these changes

@juanarbol juanarbol juanarbol approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@aduh95 @nodejs-github-bot @Trott @benjamingr @juanarbol