Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update lint-md dependencies #40404

Closed
wants to merge 1 commit into from
Closed

Conversation

Trott
Copy link
Member

@Trott Trott commented Oct 11, 2021

Update lint-md dependencies and re-create lint-md.mjs.

Update lint-md dependencies and re-create lint-md.mjs.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 11, 2021
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 11, 2021
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do we still have CJS dependencies?

@aduh95
Copy link
Contributor

aduh95 commented Oct 11, 2021

Do we still have CJS dependencies?

So none of our direct dependencies are CJS, but some of our sub-dependencies are, so we still need the rollup plugin.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2021
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2021
@github-actions
Copy link
Contributor

Landed in 983b757...350a95b

@github-actions github-actions bot closed this Oct 13, 2021
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2021
Update lint-md dependencies and re-create lint-md.mjs.

PR-URL: #40404
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
targos pushed a commit that referenced this pull request Nov 4, 2021
Update lint-md dependencies and re-create lint-md.mjs.

PR-URL: #40404
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
1 task
@Trott Trott deleted the lint-md-updates branch September 25, 2022 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants