src,stream: remove *Check*() calls from non-Initialize() functions
#40425
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
c++
addaleax
approved these changes
Oct 12, 2021
RaisinTen
force-pushed
the
src,stream/remove-Check-calls-from-non-Initialize-functions
branch
from
636defd
to
8e5c7e6
Compare
addaleax
approved these changes
Oct 12, 2021
There is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com>
RaisinTen
force-pushed
the
src,stream/remove-Check-calls-from-non-Initialize-functions
branch
from
8e5c7e6
to
bf5fc6b
Compare
addaleax
approved these changes
Oct 12, 2021
Mesteery
added
request-ci
github-actions
bot
removed
the
request-ci
This comment has been minimized.
This comment has been minimized.
22 tasks
RaisinTen
added
the
author ready
This was referenced Oct 14, 2021
RaisinTen
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
|
Landed in 7ed303b...516cdcd |
nodejs-github-bot
pushed a commit
that referenced
this pull request
Oct 20, 2021
There is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40425 Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen
deleted the
src,stream/remove-Check-calls-from-non-Initialize-functions
branch
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
There is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40425 Reviewed-By: Anna Henningsen <anna@addaleax.net>
|
Does this commit sometimes raise error as below |
|
@yulodl No, it doesn’t. |
BethGriggs
pushed a commit
that referenced
this pull request
Nov 23, 2021
There is no need to crash the process if any of these checks fail. Signed-off-by: Darshan Sen <darshan.sen@postman.com> PR-URL: #40425 Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen
added a commit
to RaisinTen/node
that referenced
this pull request
May 29, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
pushed a commit
that referenced
this pull request
Jun 2, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
italojs
pushed a commit
to italojs/node
that referenced
this pull request
Jun 6, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 11, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 13, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 12, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
targos
pushed a commit
that referenced
this pull request
Jul 31, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: #40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
guangwong
pushed a commit
to noslate-project/node
that referenced
this pull request
Oct 10, 2022
This moves the V8 calls during the StreamPipe construction to an overload of StreamPipe::New(), so that it is possible to indicate if there is a pending exception/termination. Refs: nodejs/node#40425 (comment) Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs/node#43240 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There is no need to crash the process if any of these checks fail.
Signed-off-by: Darshan Sen darshan.sen@postman.com