meta: update AUTHORS #40485
Closed
meta: update AUTHORS #40485
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
aduh95
added
the
author ready
Trott
approved these changes
Oct 17, 2021
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
aduh95
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40485 ✔ Done loading data for nodejs/node/pull/40485 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40485) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40485 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40485 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Oct 2021 00:13:59 GMT ✔ Approvals: 2 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40485#pullrequestreview-781424019 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40485#pullrequestreview-781453166 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1351614168 |
lpinca
approved these changes
Oct 17, 2021
lpinca
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40485 ✔ Done loading data for nodejs/node/pull/40485 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40485) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Node.js GitHub Bot PR-URL: https://github.com/nodejs/node/pull/40485 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40485 Reviewed-By: Antoine du Hamel Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 17 Oct 2021 00:13:59 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40485#pullrequestreview-781424019 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40485#pullrequestreview-781453166 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40485#pullrequestreview-781476689 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1351984207 |
lpinca
pushed a commit
that referenced
this pull request
Oct 17, 2021
PR-URL: #40485 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in c0a7020. |
2 tasks
targos
pushed a commit
that referenced
this pull request
Nov 4, 2021
PR-URL: #40485 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.js.