doc: fix environment variable settings for ccache #40550

Trott · 2021-10-21T17:15:20Z

macOS requires cc and c++ rather than gcc and g++.

Closes: #40542

GeoffreyBooth

Closes #40542

BUILDING.md

mscdex · 2021-10-22T01:23:27Z

BUILDING.md

-$ ccache -o cache_dir=<tmp_dir>
-$ ccache -o max_size=5.0G


Should we be dropping these?

Should we be dropping these?

ccache has a reasonable default for cache_dir so that removes the necessity to set a cache_dir explicitly. Ref: https://ccache.dev/manual/4.3.html#config_cache_dir

max_size default is 5Gb, so we don't need the step that explicitly sets it to 5Gb as well. Ref: https://ccache.dev/manual/4.3.html#config_max_size

BUILDING.md

github-actions · 2021-10-24T13:53:49Z

Commit Queue failed

- Loading data for nodejs/node/pull/40550 ✔ Done loading data for nodejs/node/pull/40550 ----------------------------------- PR info ------------------------------------ Title doc: fix environment variable settings for ccache (#40550) Author Rich Trott (@Trott) Branch Trott:build-ccache -> nodejs:master Labels doc, build, author ready Commits 3 - doc: fix environment variable settings for ccache - doc: format BUILDING.md - doc: simplify ccache instructions Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40550 Fixes: https://github.com/nodejs/node/issues/40542 Reviewed-By: Geoffrey Booth Reviewed-By: Antoine du Hamel Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 21 Oct 2021 17:15:20 GMT ✔ Approvals: 3 ✔ - Geoffrey Booth (@GeoffreyBooth): https://github.com/nodejs/node/pull/40550#pullrequestreview-785998018 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40550#pullrequestreview-786016926 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40550#pullrequestreview-786090196 ✔ Last GitHub Actions successful ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ No git cherry-pick in progress ✔ No git am in progress ✔ No git rebase in progress -------------------------------------------------------------------------------- - Bringing origin/master up to date... From https://github.com/nodejs/node * branch master -> FETCH_HEAD ✔ origin/master is now up-to-date - Downloading patch for 40550 From https://github.com/nodejs/node * branch refs/pull/40550/merge -> FETCH_HEAD ✔ Fetched commits as 40d890d31d6f..b57e2b0a64be -------------------------------------------------------------------------------- Auto-merging BUILDING.md [master e7817f7d32] doc: fix environment variable settings for ccache Author: Rich Trott Date: Thu Oct 21 10:06:49 2021 -0700 1 file changed, 12 insertions(+) Auto-merging BUILDING.md The previous cherry-pick is now empty, possibly due to conflict resolution. If you wish to commit it anyway, use:

git commit --allow-empty

Otherwise, please use 'git cherry-pick --skip'
On branch master
Your branch is ahead of 'origin/master' by 1 commit.
(use "git push" to publish your local commits)

Cherry-pick currently in progress.
(run "git cherry-pick --continue" to continue)
(use "git cherry-pick --skip" to skip this patch)
(use "git cherry-pick --abort" to cancel the cherry-pick operation)

Untracked files:
(use "git add ..." to include in what will be committed)
output

nothing added to commit but untracked files present (use "git add" to track)
✖ Failed to apply patches

https://github.com/nodejs/node/actions/runs/1377942911

macOS requires `cc` and `c++` rather than `gcc` and `g++`. Closes: nodejs#40542 PR-URL: nodejs#40550 Fixes: nodejs#40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: nodejs#40550 Fixes: nodejs#40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Trott · 2021-10-24T14:00:30Z

Landed in 40d890d...31d7d6c

macOS requires `cc` and `c++` rather than `gcc` and `g++`. Closes: #40542 PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

macOS requires `cc` and `c++` rather than `gcc` and `g++`. Closes: #40542 PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

`ccache` has reasonable defaults for `max_size` and `cache_dir` so remove instructions to set those things explicitly. Change fenced code from `console` to `bash` for easier copy/paste. PR-URL: #40550 Fixes: #40542 Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 21, 2021

This comment has been minimized.

Sign in to view

Trott force-pushed the build-ccache branch from 43de2c0 to 418932f Compare October 21, 2021 17:19

GeoffreyBooth approved these changes Oct 21, 2021

View reviewed changes

aduh95 approved these changes Oct 21, 2021

View reviewed changes

BUILDING.md Outdated Show resolved Hide resolved

BUILDING.md Outdated Show resolved Hide resolved

Trott force-pushed the build-ccache branch from fd5285f to b57e2b0 Compare October 21, 2021 18:08

Mesteery added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 21, 2021

lpinca approved these changes Oct 21, 2021

View reviewed changes

mscdex reviewed Oct 22, 2021

View reviewed changes

targos reviewed Oct 22, 2021

View reviewed changes

BUILDING.md Show resolved Hide resolved

Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 24, 2021

github-actions bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Oct 24, 2021

Trott force-pushed the build-ccache branch from b57e2b0 to c5c5f9b Compare October 24, 2021 13:58

Trott added 2 commits October 24, 2021 06:59

Trott force-pushed the build-ccache branch from c5c5f9b to 31d7d6c Compare October 24, 2021 13:59

Trott merged commit 31d7d6c into nodejs:master Oct 24, 2021

Trott deleted the build-ccache branch October 24, 2021 14:01

targos mentioned this pull request Nov 8, 2021

v17.1.0 release proposal #40758

Merged

BethGriggs mentioned this pull request Nov 26, 2021

v16.13.1 proposal #40974

Merged

1 task

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

doc: fix environment variable settings for ccache #40550

doc: fix environment variable settings for ccache #40550

Trott commented Oct 21, 2021

This comment has been minimized.

GeoffreyBooth left a comment

mscdex Oct 22, 2021

Trott Oct 22, 2021

github-actions bot commented Oct 24, 2021

Trott commented Oct 24, 2021 •

edited

doc: fix environment variable settings for ccache #40550

doc: fix environment variable settings for ccache #40550

Conversation

Trott commented Oct 21, 2021

This comment has been minimized.

GeoffreyBooth left a comment

Choose a reason for hiding this comment

mscdex Oct 22, 2021

Choose a reason for hiding this comment

Trott Oct 22, 2021

Choose a reason for hiding this comment

github-actions bot commented Oct 24, 2021

Trott commented Oct 24, 2021 • edited

Trott commented Oct 24, 2021 •

edited