doc: fix entry for Slack channel in onboarding.md #40563
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
aduh95
approved these changes
Oct 22, 2021
cjihrig
approved these changes
Oct 22, 2021
VoltrexKeyva
approved these changes
Oct 22, 2021
Trott
added
the
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40563 ✔ Done loading data for nodejs/node/pull/40563 ----------------------------------- PR info ------------------------------------ Title doc: fix entry for Slack channel in onboarding.md (#40563) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:master Labels doc, fast-track Commits 1 - doc: fix entry for Slack channel in onboarding.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40563 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Voltrex ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40563 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Voltrex -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 22 Oct 2021 15:41:30 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40563#pullrequestreview-787021121 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40563#pullrequestreview-787062519 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40563#pullrequestreview-787094238 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1373145573 |
github-actions
bot
added
the
commit-queue-failed
Trott
added
commit-queue
github-actions
bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/40563 ✔ Done loading data for nodejs/node/pull/40563 ----------------------------------- PR info ------------------------------------ Title doc: fix entry for Slack channel in onboarding.md (#40563) Author Rich Trott (@Trott) Branch Trott:Trott-patch-1 -> nodejs:master Labels doc, fast-track Commits 1 - doc: fix entry for Slack channel in onboarding.md Committers 1 - GitHub PR-URL: https://github.com/nodejs/node/pull/40563 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Voltrex ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40563 Reviewed-By: Antoine du Hamel Reviewed-By: Colin Ihrig Reviewed-By: Voltrex -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 22 Oct 2021 15:41:30 GMT ✔ Approvals: 3 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/40563#pullrequestreview-787021121 ✔ - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/40563#pullrequestreview-787062519 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40563#pullrequestreview-787094238 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1373279962 |
github-actions
bot
added
the
commit-queue-failed
PR-URL: #40563 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
|
Landed in 3d3aa5d |
Mesteery
added
the
author ready
targos
pushed a commit
that referenced
this pull request
Oct 23, 2021
PR-URL: #40563 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 24, 2021
PR-URL: #40563 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.