From 78b91ead787347bdc1b94cc14978771f3bfe5d50 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 22 Oct 2021 10:26:39 -0700 Subject: [PATCH 1/2] doc: update onboarding task Make starting Jenkins CI optional. --- onboarding.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/onboarding.md b/onboarding.md index bc761510b98bae..131ab21037ec8c 100644 --- a/onboarding.md +++ b/onboarding.md @@ -215,7 +215,9 @@ needs to be pointed out separately during the onboarding. labels. The `fast-track` label should cause the Node.js GitHub bot to post a comment in the pull request asking collaborators to approve the pull request by leaving a 👍 reaction on the comment. -* Run CI on the pull request. Use the `node-test-pull-request` CI task. +* Optional: Run CI on the pull request. Use the `node-test-pull-request` CI + task. As a convenience, you may apply the `request-ci` label to the pull + request and to have the Node.js GitHub bot start the Jenkins CI task for you. * After two Collaborator approvals for the change and two Collaborator approvals for fast-tracking, land the PR. * If there are not enough approvals within a reasonable time, consider the From f2782162c00d1452ccd094a60af6a646939608f6 Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Fri, 22 Oct 2021 22:00:33 +0000 Subject: [PATCH 2/2] fixup! doc: update onboarding task --- onboarding.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/onboarding.md b/onboarding.md index 131ab21037ec8c..bb131ef48cf107 100644 --- a/onboarding.md +++ b/onboarding.md @@ -217,7 +217,7 @@ needs to be pointed out separately during the onboarding. by leaving a 👍 reaction on the comment. * Optional: Run CI on the pull request. Use the `node-test-pull-request` CI task. As a convenience, you may apply the `request-ci` label to the pull - request and to have the Node.js GitHub bot start the Jenkins CI task for you. + request to have a GitHub Actions workflow start the Jenkins CI task for you. * After two Collaborator approvals for the change and two Collaborator approvals for fast-tracking, land the PR. * If there are not enough approvals within a reasonable time, consider the