Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: fix bug in prefer-primordials ESLint rule #40628

Merged
merged 1 commit into from Nov 4, 2021
Merged

tools: fix bug in prefer-primordials ESLint rule #40628

merged 1 commit into from Nov 4, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Oct 27, 2021

Refs: #40622

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Oct 27, 2021
@aduh95 aduh95 force-pushed the fix-prefer-primordials-bug branch 2 times, most recently from 1e1822b to 899670a Compare October 27, 2021 14:52
@aduh95 aduh95 mentioned this pull request Oct 27, 2021
Closed
targos
targos approved these changes Oct 27, 2021
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM based on added tests.

@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 27, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 27, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@Mesteery Mesteery removed the needs-ci PRs that need a full CI run. label Oct 27, 2021
@github-actions github-actions bot mentioned this pull request Oct 28, 2021
Open
30 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 29, 2021
Open
33 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
aduh95 added a commit to nodejs/node-auto-test that referenced this pull request Oct 29, 2021
@aduh95
doc: update README fot testing gh squashung (#34)
aea63a1 
commit 958a05db7e7d9ec62e3aea119aad10c7cfd39ba6
Author: Antoine du Hamel <duhamelantoine1995@gmail.com>
Date:   Wed Oct 27 16:17:05 2021 +0200

    tools: fix bug in `prefer-primordials` ESLint rule
    
    Refs: nodejs/node#40622
    
    PR-URL: nodejs/node#40628
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
@github-actions github-actions bot mentioned this pull request Oct 30, 2021
Open
35 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@github-actions github-actions bot mentioned this pull request Oct 31, 2021
Open
34 tasks
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Nov 1, 2021
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40663/

This was referenced Nov 3, 2021
Open
Open
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40696/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/40700/

@aduh95 aduh95 merged commit 8fce09e into nodejs:master Nov 4, 2021
@aduh95 aduh95 deleted the fix-prefer-primordials-bug branch November 4, 2021 17:04
This was referenced Nov 5, 2021
Open
Open
targos pushed a commit that referenced this pull request Nov 6, 2021
@aduh95 @targos
tools: fix bug in prefer-primordials ESLint rule
50d102e 
Refs: #40622

PR-URL: #40628
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Nov 7, 2021
Open
Open
@targos targos mentioned this pull request Nov 8, 2021
Merged
@github-actions github-actions bot mentioned this pull request Nov 9, 2021
Open
23 tasks
BethGriggs pushed a commit that referenced this pull request Nov 25, 2021
@aduh95 @BethGriggs
tools: fix bug in prefer-primordials ESLint rule
48a785e 
Refs: #40622

PR-URL: #40628
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@aduh95 @nodejs-github-bot @jasnell @targos @VoltrexKeyva @Mesteery