meta: update AUTHORS #40668
Closed
meta: update AUTHORS #40668
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
Trott
approved these changes
Oct 31, 2021
Trott
added
author ready
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
lpinca
approved these changes
Oct 31, 2021
Trott
force-pushed
the
actions/authors-update
branch
from
bafa049
to
f5f3d82
Compare
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40668 ✔ Done loading data for nodejs/node/pull/40668 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40668) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40668 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40668 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - meta: update AUTHORS ℹ This PR was created on Sun, 31 Oct 2021 00:14:08 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40668#pullrequestreview-793660012 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40668#pullrequestreview-793750535 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1409997070 |
Trott
approved these changes
Nov 1, 2021
Trott
added
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40668 ✔ Done loading data for nodejs/node/pull/40668 ----------------------------------- PR info ------------------------------------ Title meta: update AUTHORS (#40668) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch nodejs-github-bot:actions/authors-update -> nodejs:master Labels meta, fast-track, author ready Commits 1 - meta: update AUTHORS Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40668 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40668 Reviewed-By: Rich Trott Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Sun, 31 Oct 2021 00:14:08 GMT ✔ Approvals: 2 ✔ - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/40668#pullrequestreview-794710965 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40668#pullrequestreview-793750535 ℹ This PR is being fast-tracked ✖ GitHub CI is still running ℹ Green GitHub Actions CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1410012872 |
Trott
pushed a commit
that referenced
this pull request
Nov 1, 2021
PR-URL: #40668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Trott
force-pushed
the
actions/authors-update
branch
from
f5f3d82
to
6d0b4df
Compare
|
Landed in 6d0b4df |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
PR-URL: #40668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
PR-URL: #40668 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Here are some new additions to the AUTHORS file. This is an automatically generated PR by the
authors.ymlGitHub Action, which runstools/update-authors.js.