Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: add note about pip being required #40669

Closed
wants to merge 4 commits into from

Conversation

PiotrRybak
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations. labels Oct 31, 2021
BUILDING.md Outdated Show resolved Hide resolved
BUILDING.md Outdated

FreeBSD and OpenBSD users may also need to install `libexecinfo`.

#### macOS prerequisites

* Xcode Command Line Tools >= 11 for macOS
* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above)
* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This and the package references above should be changed as well.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've updated this and moved the pip install packages to the end of package list (so it's slightly easier to remove them if someone doesn't want them).

It feels that it's better to keep them together than make the install instructions longer with 2 versions, but please let me know if you disagree.

@Ayase-252 Ayase-252 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 3, 2021
aduh95 pushed a commit that referenced this pull request Dec 10, 2021
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Dec 10, 2021

Landed in c4aed2f

@aduh95 aduh95 closed this Dec 10, 2021
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: nodejs#40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
Clean install requires pip to make coverage but instructions didn't
mention it.

PR-URL: #40669
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. build Issues and PRs related to build files or the CI. doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants