From 1248fdaf3227b21a93d031dd55b060786f4a6fe4 Mon Sep 17 00:00:00 2001 From: Piotr Rybak Date: Sat, 30 Oct 2021 19:55:20 +0900 Subject: [PATCH 1/4] doc: remove extra 'or' --- BUILDING.md | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index a3faef3e288ddc..b35a9f2b718759 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -233,7 +233,7 @@ The Node.js project supports Python >= 3 for building and testing. #### Unix prerequisites -* `gcc` and `g++` >= 8.3 or newer, or +* `gcc` and `g++` >= 8.3 or newer * GNU Make 3.81 or newer * Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) From 80698d4cda6a6e3519c5d98c3616d63154982726 Mon Sep 17 00:00:00 2001 From: Piotr Rybak Date: Sun, 31 Oct 2021 11:50:41 +0900 Subject: [PATCH 2/4] doc: add note about pip being required Clean install requires pip to make coverage but instructions didn't mention it. --- BUILDING.md | 14 +++++++------- 1 file changed, 7 insertions(+), 7 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index b35a9f2b718759..e031b3734b7918 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -235,22 +235,22 @@ The Node.js project supports Python >= 3 for building and testing. * `gcc` and `g++` >= 8.3 or newer * GNU Make 3.81 or newer -* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) +* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed Installation via Linux package manager can be achieved with: -* Ubuntu, Debian: `sudo apt-get install python3 g++ make` -* Fedora: `sudo dnf install python3 gcc-c++ make` -* CentOS and RHEL: `sudo yum install python3 gcc-c++ make` -* OpenSUSE: `sudo zypper install python3 gcc-c++ make` -* Arch Linux, Manjaro: `sudo pacman -S python gcc make` +* Ubuntu, Debian: `sudo apt-get install python3 python3-pip g++ make` +* Fedora: `sudo dnf install python3 python3-pip gcc-c++ make` +* CentOS and RHEL: `sudo yum install python3 python3-pip gcc-c++ make` +* OpenSUSE: `sudo zypper install python3 python3-pip gcc-c++ make` +* Arch Linux, Manjaro: `sudo pacman -S python python-pip gcc make` FreeBSD and OpenBSD users may also need to install `libexecinfo`. #### macOS prerequisites * Xcode Command Line Tools >= 11 for macOS -* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) +* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed macOS users can install the `Xcode Command Line Tools` by running `xcode-select --install`. Alternatively, if you already have the full Xcode From 76bbeceb5c95dff5d4933365d0b8705f6ec4ac58 Mon Sep 17 00:00:00 2001 From: PiotrRybak Date: Sun, 31 Oct 2021 15:16:49 +0900 Subject: [PATCH 3/4] doc: put information about pip in sub-bullet --- BUILDING.md | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/BUILDING.md b/BUILDING.md index e031b3734b7918..f91d117ab42209 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -235,7 +235,8 @@ The Node.js project supports Python >= 3 for building and testing. * `gcc` and `g++` >= 8.3 or newer * GNU Make 3.81 or newer -* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed +* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) + * For test coverage, your Python installation must include pip. Installation via Linux package manager can be achieved with: From 293e5188bacfe519d2b0269c967bd41ea87d85aa Mon Sep 17 00:00:00 2001 From: Piotr Rybak Date: Mon, 1 Nov 2021 20:56:14 +0900 Subject: [PATCH 4/4] doc: update mac instructions, move pip to the end of dependencie --- BUILDING.md | 13 +++++++------ 1 file changed, 7 insertions(+), 6 deletions(-) diff --git a/BUILDING.md b/BUILDING.md index f91d117ab42209..9e98b3fc48d69d 100644 --- a/BUILDING.md +++ b/BUILDING.md @@ -240,18 +240,19 @@ The Node.js project supports Python >= 3 for building and testing. Installation via Linux package manager can be achieved with: -* Ubuntu, Debian: `sudo apt-get install python3 python3-pip g++ make` -* Fedora: `sudo dnf install python3 python3-pip gcc-c++ make` -* CentOS and RHEL: `sudo yum install python3 python3-pip gcc-c++ make` -* OpenSUSE: `sudo zypper install python3 python3-pip gcc-c++ make` -* Arch Linux, Manjaro: `sudo pacman -S python python-pip gcc make` +* Ubuntu, Debian: `sudo apt-get install python3 g++ make python3-pip` +* Fedora: `sudo dnf install python3 gcc-c++ make python3-pip` +* CentOS and RHEL: `sudo yum install python3 gcc-c++ make python3-pip` +* OpenSUSE: `sudo zypper install python3 gcc-c++ make python3-pip` +* Arch Linux, Manjaro: `sudo pacman -S python gcc make python-pip` FreeBSD and OpenBSD users may also need to install `libexecinfo`. #### macOS prerequisites * Xcode Command Line Tools >= 11 for macOS -* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) with pip installed +* Python 3.6, 3.7, 3.8, 3.9, or 3.10 (see note above) + * For test coverage, your Python installation must include pip. macOS users can install the `Xcode Command Line Tools` by running `xcode-select --install`. Alternatively, if you already have the full Xcode