test,doc: correct documentation for runBenchmark() #40683
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
|
s/Bemnchmark/Benchmark/ |
targos
approved these changes
Nov 1, 2021
Trott
changed the title
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Nov 1, 2021
richardlau
approved these changes
Nov 1, 2021
VoltrexKeyva
approved these changes
Nov 1, 2021
lpinca
approved these changes
Nov 1, 2021
Trott
added
the
commit-queue
github-actions
bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/40683 ✔ Done loading data for nodejs/node/pull/40683 ----------------------------------- PR info ------------------------------------ Title test,doc: correct documentation for runBenchmark() (#40683) Author Rich Trott (@Trott) Branch Trott:runBenchmark -> nodejs:master Labels test, fast-track, needs-ci Commits 1 - test,doc: correct documentation for runBenchmark() Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/40683 Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Voltrex Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/40683 Reviewed-By: Michaël Zasso Reviewed-By: Tobias Nießen Reviewed-By: Richard Lau Reviewed-By: Voltrex Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - test,doc: correct documentation for runBenchmark() ℹ This PR was created on Mon, 01 Nov 2021 04:39:49 GMT ✔ Approvals: 5 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/40683#pullrequestreview-793889485 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/40683#pullrequestreview-794110285 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/40683#pullrequestreview-794112267 ✔ - Voltrex (@VoltrexMaster): https://github.com/nodejs/node/pull/40683#pullrequestreview-794320002 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/40683#pullrequestreview-794618497 ℹ This PR is being fast-tracked ✔ Last GitHub Actions successful ✖ No Jenkins CI runs detected -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1409997070 |
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Nov 1, 2021
The function only takes two arguments. PR-URL: nodejs#40683 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
|
Landed in f867b61 |
targos
pushed a commit
that referenced
this pull request
Nov 6, 2021
The function only takes two arguments. PR-URL: #40683 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
BethGriggs
pushed a commit
that referenced
this pull request
Nov 25, 2021
The function only takes two arguments. PR-URL: #40683 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Voltrex <mohammadkeyvanzade94@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The function only takes two arguments.