Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[v16.x] Revert "doc: fix typo in stream docs" #40819

Closed
wants to merge 1 commit into from
Closed

[v16.x] Revert "doc: fix typo in stream docs" #40819

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Nov 15, 2021

This reverts commit 1db2ffd.

Fixes: #40818

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem. v16.x labels Nov 15, 2021
@lpinca lpinca changed the title Revert "doc: fix typo in stream docs" [v16.x] Revert "doc: fix typo in stream docs" Nov 15, 2021
richardlau
richardlau approved these changes Nov 15, 2021
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A separate PR will also be required to update the metadata in master.

@targos
Copy link
Member

targos commented Nov 16, 2021

Do we know how it happened (so we can try to prevent it in the future)?

@lpinca
Copy link
Member Author

lpinca commented Nov 16, 2021

@targos I think #40337 was incorrectly backported due to missing labels.

@targos
Copy link
Member

targos commented Nov 16, 2021

@lpinca Adding the labels beforehand is ideal, but my experience is that they are more often forgotten than added. It's still many times up to the releaser to decide whether to backport (fix the conflict) or not (add the label(s)).

BethGriggs pushed a commit that referenced this pull request Nov 24, 2021
@lpinca @BethGriggs
Revert "doc: fix typo in stream docs"
836fc27 
This reverts commit 1db2ffd.

Fixes: #40818

PR-URL: #40819
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@BethGriggs
Copy link
Member

Landed in 836fc27 (v16.x-staging)

@BethGriggs BethGriggs closed this Nov 24, 2021
@BethGriggs BethGriggs mentioned this pull request Nov 26, 2021
Merged
1 task
@lpinca lpinca deleted the fix/issue-40818 branch November 29, 2021 10:22
@richardlau richardlau mentioned this pull request Feb 17, 2022
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@BethGriggs BethGriggs BethGriggs approved these changes

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. stream Issues and PRs related to the stream subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@lpinca @targos @BethGriggs @jasnell @richardlau @nodejs-github-bot