Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typings: add types for symbol and accessor properties on primordials #40992

Conversation

ExE-Boss
Copy link
Contributor

I also fixed the types of primordials.uncurryThis and primordials.AsyncIteratorPrototype, added %TypedArray% statics, and made global properties use:

export import NAME = globalThis.NAME;

In order to re‑export types as well as values.

@ExE-Boss ExE-Boss force-pushed the typings/primordials/add-symbol-and-accessor-properties branch from 686be5a to f4c00aa Compare November 27, 2021 14:03
@ExE-Boss ExE-Boss changed the title typings(primordials): Add types for symbol and accessor properties typings: Add types for symbol and accessor properties on primordials Nov 27, 2021
@ExE-Boss ExE-Boss force-pushed the typings/primordials/add-symbol-and-accessor-properties branch from f4c00aa to b2b15f1 Compare November 27, 2021 14:04
@ExE-Boss ExE-Boss changed the title typings: Add types for symbol and accessor properties on primordials typings: add types for symbol and accessor properties on primordials Nov 27, 2021
@aduh95
Copy link
Contributor

aduh95 commented Nov 29, 2021

made global properties use:

export import NAME = globalThis.NAME;

In order to re‑export types as well as values.

Does this matter in a .d.ts file? My understanding was we were only dealing with types in those files, not values.

@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 30, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/40992
✔  Done loading data for nodejs/node/pull/40992
----------------------------------- PR info ------------------------------------
Title      typings: add types for symbol and accessor properties on `primordials` (#40992)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     ExE-Boss:typings/primordials/add-symbol-and-accessor-properties -> nodejs:master
Labels     typings
Commits    1
 - typings: add types for symbol and accessor properties on `primordials`
Committers 1
 - ExE Boss 
PR-URL: https://github.com/nodejs/node/pull/40992
Reviewed-By: James M Snell 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/40992
Reviewed-By: James M Snell 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 27 Nov 2021 14:01:05 GMT
   ✔  Approvals: 1
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/40992#pullrequestreview-817916369
   ✖  Last GitHub CI failed
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1639087835

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 30, 2021
@aduh95 aduh95 merged commit c93ba41 into nodejs:master Dec 30, 2021
@aduh95
Copy link
Contributor

aduh95 commented Dec 30, 2021

Landed in c93ba41

@ExE-Boss ExE-Boss deleted the typings/primordials/add-symbol-and-accessor-properties branch December 31, 2021 10:44
targos pushed a commit that referenced this pull request Jan 14, 2022
PR-URL: #40992
Reviewed-By: James M Snell <jasnell@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
PR-URL: #40992
Reviewed-By: James M Snell <jasnell@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #40992
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
commit-queue-failed An error occurred while landing this pull request using GitHub Actions. typings
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants