doc: specify that message.socket can be nulled
#41014
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: nodejs#41011
nodejs-github-bot
added
doc
lpinca
commented
Nov 29, 2021
| @@ -2321,7 +2321,7 @@ client's authentication details. | |||
|
|
|||
| This property is guaranteed to be an instance of the {net.Socket} class, | |||
| a subclass of {stream.Duplex}, unless the user specified a socket | |||
| type other than {net.Socket}. | |||
| type other than {net.Socket} or internally nulled. | |||
There was a problem hiding this comment.
I think it is better to not go into details and specify when this happens.
jasnell
approved these changes
Nov 29, 2021
ronag
approved these changes
Nov 29, 2021
lpinca
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 255b1db |
danielleadams
pushed a commit
that referenced
this pull request
Dec 13, 2021
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: #41011 PR-URL: #41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Dec 14, 2021
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: #41011 PR-URL: #41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Jan 31, 2022
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: #41011 PR-URL: #41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: nodejs#41011 PR-URL: nodejs#41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
The `socket` property of the `IncomingMessage` object is nulled on the server after calling `message.destroy()` and on the client after a request completes and the socket is kept alive. Fixes: #41011 PR-URL: #41014 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Robert Nagy <ronagy@icloud.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
socketproperty of theIncomingMessageobject is nulled on theserver after calling
message.destroy()and on the client after arequest completes and the socket is kept alive.
Fixes: #41011