Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add note to net.isIP() about limitations #41028

Merged
merged 1 commit into from Dec 2, 2021
Merged

doc: add note to net.isIP() about limitations #41028

merged 1 commit into from Dec 2, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 30, 2021

Closes: #40966

@Trott Trott requested a review from mscdex November 30, 2021 02:47
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem. labels Nov 30, 2021
@mscdex
Copy link
Contributor

mscdex commented Nov 30, 2021 •
edited

I would probably just be explicit about it and say the only accepted format for IPv4 addresses is the traditional/conventional quad-dotted decimal notation (which should imply base 10 numbers only for each octet).

@jasnell
Copy link
Member

jasnell commented Nov 30, 2021

I agree that it would be better to be more explicit. Also, some examples would be nice as not everyone will be immediately familiar with what "conventional IP format" means.

@Trott
Copy link
Member Author

Trott commented Dec 2, 2021

@mscdex @jasnell Updated with more explicit explanation and code examples. PTAL.

@mscdex
Copy link
Contributor

mscdex commented Dec 2, 2021

LGTM

MylesBorins
MylesBorins approved these changes Dec 2, 2021
View reviewed changes
Copy link
Member

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
@nodejs-github-bot nodejs-github-bot merged commit 97b8eb6 into nodejs:master Dec 2, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 97b8eb6

@Trott Trott deleted the isIP branch December 2, 2021 21:22
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@Trott @danielleadams
doc: expand entries for isIP(), isIPv4(), and isIPv6()
6039919 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@Trott @danielleadams
doc: expand entries for isIP(), isIPv4(), and isIPv6()
b353ded 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
doc: expand entries for isIP(), isIPv4(), and isIPv6()
aef4bde 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@Trott @danielleadams
doc: expand entries for isIP(), isIPv4(), and isIPv6()
6472311 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
doc: expand entries for isIP(), isIPv4(), and isIPv6()
6032fc3 
Closes: nodejs#40966

PR-URL: nodejs#41028
Fixes: nodejs#40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
doc: expand entries for isIP(), isIPv4(), and isIPv6()
084decd 
Closes: #40966

PR-URL: #41028
Fixes: #40966
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Brian White <mscdex@mscdex.net>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MylesBorins MylesBorins MylesBorins approved these changes

@lpinca lpinca lpinca approved these changes

@mscdex mscdex Awaiting requested review from mscdex

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. net Issues and PRs related to the net subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

net.isIP fails to detect different formats
6 participants
@Trott @mscdex @jasnell @nodejs-github-bot @MylesBorins @lpinca