Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: link to commit queue guide #41030

Merged
merged 1 commit into from Dec 2, 2021
Merged

doc: link to commit queue guide #41030

merged 1 commit into from Dec 2, 2021
+6 −0

Conversation

GeoffreyBooth
Copy link
Member

This would have helped me.

@GeoffreyBooth GeoffreyBooth added the doc Issues and PRs related to the documentations. label Nov 30, 2021
@GeoffreyBooth GeoffreyBooth added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 30, 2021
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Dec 2, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41030
✔  Done loading data for nodejs/node/pull/41030
----------------------------------- PR info ------------------------------------
Title      doc: link to commit queue guide (#41030)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     GeoffreyBooth:commit-queue -> nodejs:master
Labels     doc, author ready
Commits    1
 - doc: link to commit queue guide
Committers 1
 - Geoffrey Booth 
PR-URL: https://github.com/nodejs/node/pull/41030
Reviewed-By: James M Snell 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41030
Reviewed-By: James M Snell 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Ruben Bridgewater 
Reviewed-By: Luigi Pinca 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 30 Nov 2021 06:21:44 GMT
   ✔  Approvals: 5
   ✔  - James M Snell (@jasnell) (TSC): https://github.com/nodejs/node/pull/41030#pullrequestreview-819143369
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41030#pullrequestreview-819153891
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41030#pullrequestreview-819203614
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41030#pullrequestreview-819461385
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41030#pullrequestreview-819491542
   ✖  This PR needs to wait 48 more minutes to land
   ✔  Last GitHub Actions successful
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1529194096

@GeoffreyBooth GeoffreyBooth added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 2, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 2, 2021
@nodejs-github-bot nodejs-github-bot merged commit 34fdea1 into nodejs:master Dec 2, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 34fdea1

@GeoffreyBooth GeoffreyBooth deleted the commit-queue branch December 2, 2021 06:53
danielleadams pushed a commit that referenced this pull request Dec 13, 2021
@GeoffreyBooth @danielleadams
doc: link to commit queue guide
432b49d 
PR-URL: #41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Dec 14, 2021
@GeoffreyBooth @danielleadams
doc: link to commit queue guide
f18aa14 
PR-URL: #41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Dec 14, 2021
Merged
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@GeoffreyBooth @danielleadams
doc: link to commit queue guide
c17d7da 
PR-URL: #41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
@GeoffreyBooth @danielleadams
doc: link to commit queue guide
fea8412 
PR-URL: #41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@GeoffreyBooth @Linkgoron
doc: link to commit queue guide
8e86955 
PR-URL: nodejs#41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@GeoffreyBooth @danielleadams
doc: link to commit queue guide
3f6106c 
PR-URL: #41030
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@lpinca lpinca lpinca approved these changes

@richardlau richardlau richardlau approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@aduh95 aduh95 aduh95 approved these changes

@Trott Trott Awaiting requested review from Trott

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@GeoffreyBooth @nodejs-github-bot @jasnell @lpinca @richardlau @BridgeAR @aduh95