tools,lib: enable jsdoc/require-returns-check lint rule

[Trott]

No description provided.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41348/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/41359/

[nodejs-github-bot]

Commit Queue failed

- Loading data for nodejs/node/pull/41089
✔  Done loading data for nodejs/node/pull/41089
----------------------------------- PR info ------------------------------------
Title      tools,lib: enable jsdoc/require-returns-check lint rule (#41089)
Author     Rich Trott  (@Trott)
Branch     Trott:require-returns-check -> nodejs:master
Labels     commit-queue-rebase
Commits    2
 - lib: use consistent types in JSDoc @returns
 - tools: enable jsdoc/require-returns-check lint rule
Committers 1
 - Rich Trott 
PR-URL: https://github.com/nodejs/node/pull/41089
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41089
Reviewed-By: Michaël Zasso 
Reviewed-By: Ruben Bridgewater 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sun, 05 Dec 2021 04:01:42 GMT
   ✔  Approvals: 2
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/41089#pullrequestreview-823353142
   ✔  - Ruben Bridgewater (@BridgeAR) (TSC): https://github.com/nodejs/node/pull/41089#pullrequestreview-823371068
   ✔  Last GitHub Actions successful
   ℹ  Last Full PR CI on 2021-12-05T15:59:16Z: https://ci.nodejs.org/job/node-test-pull-request/41359/
- Querying data for job/node-test-pull-request/41359/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  No git cherry-pick in progress
   ✔  No git am in progress
   ✔  No git rebase in progress
--------------------------------------------------------------------------------
- Bringing origin/master up to date...
From https://github.com/nodejs/node
 * branch                  master     -> FETCH_HEAD
✔  origin/master is now up-to-date
- Downloading patch for 41089
From https://github.com/nodejs/node
 * branch                  refs/pull/41089/merge -> FETCH_HEAD
✔  Fetched commits as 3d5a7de83c97..d3881758a276
--------------------------------------------------------------------------------
Auto-merging lib/assert.js
[master 7deab87433] lib: use consistent types in JSDoc @returns
 Author: Rich Trott 
 Date: Sat Dec 4 19:59:24 2021 -0800
 4 files changed, 3 insertions(+), 4 deletions(-)
[master 71a96e9ff9] tools: enable jsdoc/require-returns-check lint rule
 Author: Rich Trott 
 Date: Sat Dec 4 19:59:37 2021 -0800
 1 file changed, 1 deletion(-)
   ✔  Patches applied
There are 2 commits in the PR. Attempting autorebase.
Rebasing (2/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

lib: use consistent types in JSDoc @returns
PR-URL: #41089

Reviewed-By: Michaël Zasso targos@protonmail.com

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
[detached HEAD f610c03f61] lib: use consistent types in JSDoc @returns

Author: Rich Trott rtrott@gmail.com

Date: Sat Dec 4 19:59:24 2021 -0800

4 files changed, 3 insertions(+), 4 deletions(-)

Rebasing (3/4)

Rebasing (4/4)
Executing: git node land --amend --yes

--------------------------------- New Message ----------------------------------

tools: enable jsdoc/require-returns-check lint rule
PR-URL: #41089

Reviewed-By: Michaël Zasso targos@protonmail.com

Reviewed-By: Ruben Bridgewater ruben@bridgewater.de
[detached HEAD ce6a0bb7db] tools: enable jsdoc/require-returns-check lint rule

Author: Rich Trott rtrott@gmail.com

Date: Sat Dec 4 19:59:37 2021 -0800

1 file changed, 1 deletion(-)
Successfully rebased and updated refs/heads/master.
✔  f610c03f6160a5b015fd8a831ccd1f7cf9c67864

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

✔  0:0      Title is <= 50 columns.                   title-length

✔  ce6a0bb7dbf1fc055886e5709d11730e8c8136ec

✔  0:0      skipping fixes-url                        fixes-url

✔  0:0      blank line after title                    line-after-title

✔  0:0      line-lengths are valid                    line-length

✔  0:0      metadata is at end of message             metadata-end

✔  1:8      PR-URL is valid.                          pr-url

✔  0:0      reviewers are valid                       reviewers

✔  0:0      valid subsystems                          subsystem

✔  0:0      Title is formatted correctly.             title-format

⚠  0:50     Title should be <= 50 columns.            title-length
The following commits are ready to be pushed to origin/master

f610c03f61 lib: use consistent types in JSDoc @returns
ce6a0bb7db tools: enable jsdoc/require-returns-check lint rule


Temporary files removed.

To finish landing:

Run:

git push origin master
Post "Landed in 3d5a7de83c97...ce6a0bb7dbf1" in tools,lib: enable jsdoc/require-returns-check lint rule #41089

gh pr comment 41089 --body "Landed in 3d5a7de83c97...ce6a0bb7dbf1"

gh pr close 41089

fatal: could not read Username for 'https://github.com': No such device or address

https://github.com/nodejs/node/actions/runs/1549817216

[Trott]

Landed in 3d5a7de...e0a5877