From 3b18d8695ec461dd884a0dc07b1499833efab169 Mon Sep 17 00:00:00 2001 From: yaya Date: Sat, 11 Dec 2021 20:28:46 +0800 Subject: [PATCH 1/4] doc: adding estimated execution time --- doc/guides/contributing/pull-requests.md | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 0028969fa87b4b..2b9157714f82ec 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -251,7 +251,9 @@ And on Windows: > vcbuild test ``` -(See the [running tests][] section of Building guide for more details.) +(This code might take more than an hour to execute on a PC, want to run a part +of tests quickly or for more details see the [running tests][] section of Buil +ding guide.) ### Step 7: Push From 48ae57de8f5fd534e4f5db46303d22c53fc9ccf5 Mon Sep 17 00:00:00 2001 From: Derek Lewis Date: Sat, 11 Dec 2021 15:23:45 -0500 Subject: [PATCH 2/4] fixup! doc: adding estimated execution time --- doc/guides/contributing/pull-requests.md | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 2b9157714f82ec..3c51f1064ef10f 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -252,8 +252,8 @@ And on Windows: ``` (This code might take more than an hour to execute on a PC, want to run a part -of tests quickly or for more details see the [running tests][] section of Buil -ding guide.) +of tests quickly or for more details see the [running tests][] section of +Building guide.) ### Step 7: Push From 6c6957f1ce8093bb46605e0e3cdc8ccfb08d860a Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 16 Dec 2021 05:45:29 -0800 Subject: [PATCH 3/4] Update doc/guides/contributing/pull-requests.md --- doc/guides/contributing/pull-requests.md | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 3c51f1064ef10f..6dd6f6b627cc64 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -251,9 +251,8 @@ And on Windows: > vcbuild test ``` -(This code might take more than an hour to execute on a PC, want to run a part -of tests quickly or for more details see the [running tests][] section of -Building guide.) +Running all tests takes a long time (typically an hour or more). To run a subset of the +test suite, see the [running tests][] section of the Building guide. ### Step 7: Push From fcf00daa7dc6f7cb89ae6af56c30b06bff181bda Mon Sep 17 00:00:00 2001 From: Rich Trott Date: Thu, 16 Dec 2021 05:51:02 -0800 Subject: [PATCH 4/4] Update doc/guides/contributing/pull-requests.md --- doc/guides/contributing/pull-requests.md | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/doc/guides/contributing/pull-requests.md b/doc/guides/contributing/pull-requests.md index 6dd6f6b627cc64..9b6f16ac54f30e 100644 --- a/doc/guides/contributing/pull-requests.md +++ b/doc/guides/contributing/pull-requests.md @@ -251,8 +251,9 @@ And on Windows: > vcbuild test ``` -Running all tests takes a long time (typically an hour or more). To run a subset of the -test suite, see the [running tests][] section of the Building guide. +For some configurations, running all tests might take a long time (an hour or +more). To run a subset of the test suite, see the [running tests][] section of +the Building guide. ### Step 7: Push