meta: move one or more collaborators to emeritus #41154

nodejs-github-bot · 2021-12-13T04:09:33Z

This PR was generated by tools/find-inactive-collaborators.yml.

DerekNonGeneric

It would have been nice to collaborate on loaders design, especially since we still want to ensure that our still experimental API can meet the APM use case(s).

Trott · 2021-12-13T05:16:11Z

Adding blocked because our governance docs/rules are such that a collaborator can only be moved to emeritus if they agree to it or if the TSC votes to do it.

@watson @nodejs/tsc

DerekNonGeneric · 2021-12-13T06:15:50Z

@watson, do you think you'd be interested in getting re-involved?

The @nodejs/loaders team could use more input from APM vendors/those versed in the subject. I'm not sure if anyone has yet, but I meant to reach out a while back to see how we could ensure that this use case, in particular, is well-supported. We're still a couple of iterations away from stabilizing custom module loading (our hooks system), so it's not too late for feedback/collaboration if you're willing to help out. It would be good to have your thoughts on our progress and also good to know what Elastic would need as far as hooks are concerned if they intend to support newer Node.js applications (those not using CommonJS as their module format).

Please let us know; team membership is open to anyone interested in getting involved/contributing to this testing/feedback/re-engineering research & development loop we're in currently. I am also happy to dismiss my review as stale for any other reason, but if joining a new team is something you see yourself doing, Loaders might be one worth considering. 😉

Trott · 2021-12-13T06:36:26Z

I am also happy to dismiss my review

Same.

mcollina

lgtm

JakobJingleheimer · 2021-12-13T09:07:34Z

@DerekNonGeneric I did already reach out to APMs. It was discussed at at least a couple Loaders team meetings.

Automatically add `blocked` label for find-inactive-collaborators's PRs. Refs: nodejs#41154 (comment)

mhdawson

LGTM

Trott · 2021-12-15T22:01:42Z

Now that #41155 has landed, this is no longer blocked.

nodejs-github-bot · 2021-12-15T22:08:39Z

Commit Queue failed

- Loading data for nodejs/node/pull/41154
✔  Done loading data for nodejs/node/pull/41154
----------------------------------- PR info ------------------------------------
Title      meta: move one or more collaborators to emeritus (#41154)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     nodejs-github-bot:actions/inactive-collaborators -> nodejs:master
Labels     doc, meta
Commits    1
 - meta: move one or more collaborators to emeritus
Committers 1
 - Node.js GitHub Bot 
PR-URL: https://github.com/nodejs/node/pull/41154
Reviewed-By: Derek Lewis 
Reviewed-By: Rich Trott 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Richard Lau 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41154
Reviewed-By: Derek Lewis 
Reviewed-By: Rich Trott 
Reviewed-By: Matteo Collina 
Reviewed-By: Antoine du Hamel 
Reviewed-By: Colin Ihrig 
Reviewed-By: Tobias Nießen 
Reviewed-By: Joyee Cheung 
Reviewed-By: Luigi Pinca 
Reviewed-By: Michael Dawson 
Reviewed-By: Richard Lau 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Mon, 13 Dec 2021 04:09:33 GMT
   ✔  Approvals: 10
   ✔  - Derek Lewis (@DerekNonGeneric): https://github.com/nodejs/node/pull/41154#pullrequestreview-829762431
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829778163
   ✔  - Matteo Collina (@mcollina) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829838497
   ✔  - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-829909980
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830234258
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-830564675
   ✔  - Joyee Cheung (@joyeecheung) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-832762876
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41154#pullrequestreview-833365737
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833427239
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41154#pullrequestreview-833446593
   ✖  GitHub CI is still running
   ℹ  Green GitHub Actions CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1584867256

PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>

Trott · 2021-12-15T22:11:02Z

Landed in 162e5a1

Trott · 2021-12-15T22:38:02Z

I've blocked @ssua91 so we can all have a reduction in notification spam.

Refs (in addition to the two reviews in this PR)

PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: nodejs#41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>

PR-URL: #41154 Reviewed-By: Derek Lewis <DerekNonGeneric@inf.is> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Richard Lau <rlau@redhat.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. doc Issues and PRs related to the documentations. labels Dec 13, 2021

DerekNonGeneric approved these changes Dec 13, 2021

View reviewed changes

Trott added the blocked PRs that are blocked by other issues or PRs. label Dec 13, 2021

Trott approved these changes Dec 13, 2021

View reviewed changes

mcollina approved these changes Dec 13, 2021

View reviewed changes

aduh95 approved these changes Dec 13, 2021

View reviewed changes

Mesteery mentioned this pull request Dec 13, 2021

build: update find-inactive-collaborators labels #41156

Closed

Mesteery added a commit to Mesteery/node that referenced this pull request Dec 13, 2021

build: update find-inactive-collaborators labels

7e5ff77

Automatically add `blocked` label for find-inactive-collaborators's PRs. Refs: nodejs#41154 (comment)

cjihrig approved these changes Dec 13, 2021

View reviewed changes

tniessen approved these changes Dec 13, 2021

View reviewed changes

joyeecheung approved these changes Dec 15, 2021

View reviewed changes

lpinca approved these changes Dec 15, 2021

View reviewed changes

Trott added the tsc-agenda Issues and PRs to discuss during the meetings of the TSC. label Dec 15, 2021

mhdawson approved these changes Dec 15, 2021

View reviewed changes

richardlau approved these changes Dec 15, 2021

View reviewed changes

Trott added commit-queue Add this label to land a pull request using GitHub Actions. and removed blocked PRs that are blocked by other issues or PRs. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. labels Dec 15, 2021

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 15, 2021

nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 15, 2021

Trott force-pushed the actions/inactive-collaborators branch from e5260eb to 162e5a1 Compare December 15, 2021 22:11

Trott merged commit 162e5a1 into master Dec 15, 2021

DerekNonGeneric deleted the actions/inactive-collaborators branch December 15, 2021 22:12

ssua91 approved these changes Dec 15, 2021

View reviewed changes

DerekNonGeneric removed the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 16, 2021

danielleadams mentioned this pull request Dec 16, 2021

v17.3.0 release proposal #41167

Merged

Trott mentioned this pull request Dec 20, 2021

Node.js Technical Steering Committee (TSC) Meeting 2021-12-22 nodejs/TSC#1142

Closed

danielleadams mentioned this pull request Feb 1, 2022

v16.14.0 proposal #41804

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

meta: move one or more collaborators to emeritus #41154

meta: move one or more collaborators to emeritus #41154

nodejs-github-bot commented Dec 13, 2021

DerekNonGeneric left a comment •

edited

Trott commented Dec 13, 2021

DerekNonGeneric commented Dec 13, 2021

Trott commented Dec 13, 2021

mcollina left a comment

JakobJingleheimer commented Dec 13, 2021

mhdawson left a comment

Trott commented Dec 15, 2021

nodejs-github-bot commented Dec 15, 2021

Trott commented Dec 15, 2021

Trott commented Dec 15, 2021 •

edited

meta: move one or more collaborators to emeritus #41154

meta: move one or more collaborators to emeritus #41154

Conversation

nodejs-github-bot commented Dec 13, 2021

DerekNonGeneric left a comment • edited

Choose a reason for hiding this comment

Trott commented Dec 13, 2021

DerekNonGeneric commented Dec 13, 2021

Trott commented Dec 13, 2021

mcollina left a comment

Choose a reason for hiding this comment

JakobJingleheimer commented Dec 13, 2021

mhdawson left a comment

Choose a reason for hiding this comment

Trott commented Dec 15, 2021

nodejs-github-bot commented Dec 15, 2021

Trott commented Dec 15, 2021

Trott commented Dec 15, 2021 • edited

DerekNonGeneric left a comment •

edited

Trott commented Dec 15, 2021 •

edited