Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable #41235

Merged
merged 1 commit into from Jan 6, 2022
Merged

build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable #41235

merged 1 commit into from Jan 6, 2022

Conversation

dsanders11
Copy link
Contributor

@dsanders11 dsanders11 commented Dec 19, 2021 •
edited by richardlau

Looks like VCBUILD_PYTHON_LOCATION went stale at some point, and isn't read anywhere (searching the repo shows this is the only usage).

Refs: #18621

@nodejs-github-bot nodejs-github-bot added install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform. labels Dec 19, 2021
@dsanders11 dsanders11 changed the title build,tools,win: Trim unused VCBUILD_PYTHON_LOCATION variable build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable Dec 19, 2021
RaisinTen
RaisinTen approved these changes Dec 19, 2021
View reviewed changes
Copy link
Contributor

@RaisinTen RaisinTen left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uses of VCBUILD_PYTHON_LOCATION were removed in #18621, LGTM.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 19, 2021
This was referenced Dec 20, 2021
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 22, 2021
Open
Open
Open
Open
Open
Open
@nodejs-github-bot

This comment has been minimized.

Sign in to view
This was referenced Dec 28, 2021
Open
Open
Open
Open
Open
Open
Open
@github-actions github-actions bot mentioned this pull request Jan 4, 2022
Open
25 tasks
@github-actions github-actions bot mentioned this pull request Jan 5, 2022
Open
26 tasks
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/41757/

@RaisinTen RaisinTen added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 6, 2022
@nodejs-github-bot nodejs-github-bot merged commit 79b21ee into nodejs:master Jan 6, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 79b21ee

@dsanders11 dsanders11 deleted the patch-1 branch January 6, 2022 22:24
targos pushed a commit that referenced this pull request Jan 14, 2022
@dsanders11 @targos
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
2233f31 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@dsanders11 @Linkgoron
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
ea01d8a 
PR-URL: nodejs#41235
Refs: nodejs#18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@dsanders11 @danielleadams
build,tools,win: trim unused VCBUILD_PYTHON_LOCATION variable
fc38d15 
PR-URL: #41235
Refs: #18621
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@richardlau richardlau richardlau approved these changes

@RaisinTen RaisinTen RaisinTen approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. install Issues and PRs related to the installers. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. windows Issues and PRs related to the Windows platform.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@dsanders11 @nodejs-github-bot @jasnell @richardlau @RaisinTen