Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update doc dependency mdast-util-gfm-table to 1.0.2 #41260

Merged
merged 1 commit into from Dec 23, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Dec 21, 2021

This fixes a bug that causes our tooling to generate invalid HTML. (The
align attribute on tr and td elements was ending up with the
invalid value of "none".)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860

This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860
@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. tools Issues and PRs related to the tools directory. labels Dec 21, 2021
@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Dec 21, 2021
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 21, 2021
@nodejs-github-bot
Copy link
Collaborator

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Dec 21, 2021
@github-actions
Copy link
Contributor

Fast-track has been requested by @jasnell. Please 👍 to approve.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 22, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot merged commit 1c6d81e into nodejs:master Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 1c6d81e

@Trott Trott deleted the doc-bug-fix branch December 23, 2021 00:44
targos pushed a commit that referenced this pull request Jan 14, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860

PR-URL: #41260
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860

PR-URL: #41260
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860

PR-URL: nodejs#41260
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
This fixes a bug that causes our tooling to generate invalid HTML. (The
`align` attribute on `tr` and `td` elements was ending up with the
invalid value of `"none"`.)

Refs: remarkjs/remark-gfm#29
Refs: syntax-tree/mdast-util-gfm-table@a28b860

PR-URL: #41260
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants