Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

meta: update node-api team name #41268

Merged
merged 2 commits into from Dec 23, 2021
Merged

Conversation

richardlau
Copy link
Member

The @nodejs/n-api team was renamed to @nodejs/node-api.

cc @nodejs/node-api

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/tsc

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Dec 21, 2021
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.
@richardlau richardlau changed the title doc: update node-api team name meta: update node-api team name Dec 21, 2021
.github/CODEOWNERS Outdated Show resolved Hide resolved
Copy link
Member

@mhdawson mhdawson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Co-authored-by: Nicola Del Gobbo <nicoladelgobbo@gmail.com>
@richardlau richardlau added the commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. label Dec 21, 2021
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 21, 2021
@richardlau richardlau added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41268
✔  Done loading data for nodejs/node/pull/41268
----------------------------------- PR info ------------------------------------
Title      meta: update node-api team name (#41268)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     richardlau:ode-to-team -> nodejs:master
Labels     meta, author ready, commit-queue-squash
Commits    2
 - meta: update node-api team name
 - fixup! meta: update node-api team name
Committers 2
 - Richard Lau 
 - GitHub 
PR-URL: https://github.com/nodejs/node/pull/41268
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41268
Reviewed-By: Michael Dawson 
Reviewed-By: Colin Ihrig 
Reviewed-By: Anna Henningsen 
Reviewed-By: Tobias Nießen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Tue, 21 Dec 2021 19:20:48 GMT
   ✔  Approvals: 5
   ✔  - Michael Dawson (@mhdawson) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837843751
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837867874
   ✔  - Anna Henningsen (@addaleax): https://github.com/nodejs/node/pull/41268#pullrequestreview-837873680
   ✔  - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41268#pullrequestreview-837925525
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41268#pullrequestreview-838793934
   ✖  This PR needs to wait 2 more hours to land
   ✔  Last GitHub CI successful
   ℹ  Green GitHub CI is sufficient
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1616345446

@nodejs-github-bot nodejs-github-bot added the commit-queue-failed An error occurred while landing this pull request using GitHub Actions. label Dec 23, 2021
@richardlau richardlau added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Dec 23, 2021
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 23, 2021
@nodejs-github-bot nodejs-github-bot merged commit 406e6d8 into nodejs:master Dec 23, 2021
@nodejs-github-bot
Copy link
Collaborator

Landed in 406e6d8

@richardlau richardlau deleted the ode-to-team branch December 23, 2021 19:50
targos pushed a commit that referenced this pull request Jan 14, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: #41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 31, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: #41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: nodejs#41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
The `@nodejs/n-api` team was renamed to `@nodejs/node-api`.

PR-URL: #41268
Reviewed-By: Michael Dawson <midawson@redhat.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants