Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: fix argv bug in find-inactive-tsc.mjs #41394

Merged
merged 1 commit into from Jan 7, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 4, 2022

The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.
@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Jan 4, 2022
@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 4, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 7, 2022
@nodejs-github-bot nodejs-github-bot merged commit 95e1f92 into nodejs:master Jan 7, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 95e1f92

@Trott Trott deleted the plus-argv-2 branch January 7, 2022 02:02
targos pushed a commit that referenced this pull request Jan 14, 2022
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

PR-URL: #41394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

PR-URL: nodejs#41394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
The argument supplied is expected to be text, not numeric.

This wasn't causing issues with the automated job because it does not
send an argument. It uses the default.

PR-URL: #41394
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

10 participants