Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: revise HTTPRequestOptions text #41407

Merged
merged 1 commit into from Jan 8, 2022
Merged

doc: revise HTTPRequestOptions text #41407

merged 1 commit into from Jan 8, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 5, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/http
  • @nodejs/net

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem. labels Jan 5, 2022
mcollina
mcollina approved these changes Jan 5, 2022
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 6, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 8, 2022
@nodejs-github-bot nodejs-github-bot merged commit 1548578 into nodejs:master Jan 8, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 1548578

@Trott Trott deleted the doc-httprequestoptions branch January 8, 2022 05:31
targos pushed a commit that referenced this pull request Jan 14, 2022
@Trott @targos
doc: revise HTTPRequestOptions text
4a369d0 
PR-URL: #41407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@Trott @thedull
doc: revise HTTPRequestOptions text
c5f78f0 
PR-URL: nodejs#41407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@Trott @Linkgoron
doc: revise HTTPRequestOptions text
6f4682b 
PR-URL: nodejs#41407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@Trott @danielleadams
doc: revise HTTPRequestOptions text
91c3e28 
PR-URL: #41407
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mcollina mcollina mcollina approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. doc Issues and PRs related to the documentations. http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@Trott @nodejs-github-bot @mcollina @lpinca