Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove broken wiki link from test/common doc #41426

Merged
merged 1 commit into from Jan 14, 2022

Conversation

kuriyosh
Copy link
Contributor

@kuriyosh kuriyosh commented Jan 7, 2022

This remove obsolete wiki link in test/common/README.md.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 7, 2022
@richardlau richardlau added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Jan 7, 2022
@aduh95 aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/41426
✔  Done loading data for nodejs/node/pull/41426
----------------------------------- PR info ------------------------------------
Title      test: remove broken wiki link from test/common doc (#41426)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     kuriyosh:remove-broken-link-intl -> nodejs:master
Labels     test, author ready, needs-ci
Commits    1
 - test: remove broken wiki link from test/common doc
Committers 1
 - kuriyosh 
PR-URL: https://github.com/nodejs/node/pull/41426
Reviewed-By: Richard Lau 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41426
Reviewed-By: Richard Lau 
Reviewed-By: Anatoli Papirovski 
Reviewed-By: Luigi Pinca 
Reviewed-By: Rich Trott 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Fri, 07 Jan 2022 06:40:32 GMT
   ✔  Approvals: 4
   ✔  - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-846540007
   ✔  - Anatoli Papirovski (@apapirovski) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-846732722
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41426#pullrequestreview-846949575
   ✔  - Rich Trott (@Trott) (TSC): https://github.com/nodejs/node/pull/41426#pullrequestreview-847114571
   ✔  Last GitHub CI successful
   ✖  No Jenkins CI runs detected
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/1676834514

@Ayase-252
Copy link
Member

IMO, it might not need a full CI run. Maybe we could narrow the scope of files which need full CI run to test/**/*.js?

@richardlau
Copy link
Member

richardlau commented Jan 12, 2022

IMO, it might not need a full CI run. Maybe we could narrow the scope of files which need full CI run to test/**/*.js?

No, that's too narrow and would exclude any changes to the native code in the addons tests, non *.js fixtures (which look to also include some markdown files), status file updates and *.mjs files. You could potentially exclude just test/common/README.md.

@aduh95 aduh95 merged commit cd075f4 into nodejs:master Jan 14, 2022
@aduh95
Copy link
Contributor

aduh95 commented Jan 14, 2022

Landed in cd075f4

targos pushed a commit that referenced this pull request Jan 16, 2022
PR-URL: #41426
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
mawaregetsuka pushed a commit to mawaregetsuka/node that referenced this pull request Jan 17, 2022
PR-URL: nodejs#41426
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
PR-URL: nodejs#41426
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
PR-URL: nodejs#41426
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
PR-URL: #41426
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. commit-queue-failed An error occurred while landing this pull request using GitHub Actions. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants