Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

meta: correct my name in AUTHORS #41444

Merged
merged 2 commits into from Jan 10, 2022
Merged

meta: correct my name in AUTHORS #41444

merged 2 commits into from Jan 10, 2022

Conversation

JakobJingleheimer
Copy link
Contributor

@JakobJingleheimer JakobJingleheimer commented Jan 8, 2022 •
edited

My surname is currently missing in AUTHORS list.

@JakobJingleheimer JakobJingleheimer changed the title Correct my name in AUTHORS fixup: correct my name in AUTHORS Jan 8, 2022
@JakobJingleheimer JakobJingleheimer changed the title fixup: correct my name in AUTHORS meta: correct my name in AUTHORS Jan 8, 2022
@aduh95 aduh95 added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 8, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Jan 8, 2022

Fast-track has been requested by @aduh95. Please 👍 to approve.

targos
targos requested changes Jan 8, 2022
View reviewed changes
Copy link
Member

@targos targos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Did you rename the file?
There needs to be a change in .mailmap. AUTHORS is automatically generated using it and the git log.

@JakobJingleheimer
Copy link
Contributor Author

JakobJingleheimer commented Jan 8, 2022 •
edited

What the… no, I didn't (mean to) rename the file. Last time I use GitHub's web editor (that field used to be for naming the branch—now a field for naming the branch is gone, and it's apparently to rename the file 😳)

I'll rename it back and update mailmap.

Thanks @targos

@JakobJingleheimer
Copy link
Contributor Author

@targos should I remove the correction in AUTHORS (or will it just get overwritten)? Is it possible to correct it at all? My surname got omitted in some commit (that landed a while ago), and that's what go added to AUTHORS.

entry to .mailmap added.

richardlau
richardlau approved these changes Jan 8, 2022
View reviewed changes
Copy link
Member

@richardlau richardlau left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Refs: #40504 (comment)

Trott
Trott reviewed Jan 8, 2022
View reviewed changes
.mailmap Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Jan 8, 2022

Did you rename the file? There needs to be a change in .mailmap. AUTHORS is automatically generated using it and the git log.

@targos Is this resolved now?

@aduh95 aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. and removed fast-track PRs that do not need to wait for 48 hours to land. labels Jan 10, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 10, 2022
@nodejs-github-bot nodejs-github-bot merged commit f027463 into nodejs:master Jan 10, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in f027463

targos pushed a commit that referenced this pull request Jan 14, 2022
@JakobJingleheimer @targos
meta: correct my name in AUTHORS
e1ff452 
PR-URL: #41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jan 16, 2022
Merged
thedull pushed a commit to thedull/node that referenced this pull request Jan 18, 2022
@JakobJingleheimer @thedull
meta: correct my name in AUTHORS
f1e1e46 
PR-URL: nodejs#41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Linkgoron pushed a commit to Linkgoron/node that referenced this pull request Jan 31, 2022
@JakobJingleheimer @Linkgoron
meta: correct my name in AUTHORS
b8bf029 
PR-URL: nodejs#41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
danielleadams pushed a commit that referenced this pull request Feb 1, 2022
@JakobJingleheimer @danielleadams
meta: correct my name in AUTHORS
e83e416 
PR-URL: #41444
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Qingyu Deng <i@ayase-lab.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Feb 1, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@richardlau richardlau richardlau approved these changes

@Ayase-252 Ayase-252 Ayase-252 approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
7 participants
@JakobJingleheimer @Trott @nodejs-github-bot @targos @richardlau @Ayase-252 @aduh95