doc: add missing word in readable.read() text #41524
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This adds a missing _is_ in the readable.read() text and makes small style adjustments.
nodejs-github-bot
added
doc
|
To avoid any From the Microsoft Writing Style Guide:
And from doc/README.md:
|
richardlau
approved these changes
Jan 14, 2022
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
tniessen
approved these changes
Jan 14, 2022
Trott
added
the
author ready
aduh95
approved these changes
Jan 14, 2022
RaisinTen
approved these changes
Jan 14, 2022
benjamingr
approved these changes
Jan 14, 2022
|
Change LGTM. Note - in the future since terminology consistency is important and it's unfortunately pretty nuanced at times, please ping @nodejs/streams when making changes w.r.t the docs about how streams work :) |
aduh95
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 08fc4b5 |
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/41524 ✔ Done loading data for nodejs/node/pull/41524 ----------------------------------- PR info ------------------------------------ Title doc: add missing word in readable.read() text (#41524) Author Rich Trott (@Trott) Branch Trott:stream-typo -> nodejs:master Labels doc, stream, fast-track, author ready Commits 1 - doc: add missing word in readable.read() text Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/41524 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/41524 Reviewed-By: Richard Lau Reviewed-By: Tobias Nießen Reviewed-By: Antoine du Hamel Reviewed-By: Darshan Sen Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ℹ This PR was created on Fri, 14 Jan 2022 14:43:56 GMT ✔ Approvals: 5 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-852999920 ✔ - Tobias Nießen (@tniessen) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853005515 ✔ - Antoine du Hamel (@aduh95) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853008485 ✔ - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/41524#pullrequestreview-853059323 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41524#pullrequestreview-853119680 ℹ This PR is being fast-tracked ⚠ This PR was merged on Fri, 14 Jan 2022 17:42:38 GMT ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/1698846568 |
targos
pushed a commit
that referenced
this pull request
Jan 16, 2022
This adds a missing _is_ in the readable.read() text and makes small style adjustments. PR-URL: #41524 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
mawaregetsuka
pushed a commit
to mawaregetsuka/node
that referenced
this pull request
Jan 17, 2022
This adds a missing _is_ in the readable.read() text and makes small style adjustments. PR-URL: nodejs#41524 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
thedull
pushed a commit
to thedull/node
that referenced
this pull request
Jan 18, 2022
This adds a missing _is_ in the readable.read() text and makes small style adjustments. PR-URL: nodejs#41524 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Linkgoron
pushed a commit
to Linkgoron/node
that referenced
this pull request
Jan 31, 2022
This adds a missing _is_ in the readable.read() text and makes small style adjustments. PR-URL: nodejs#41524 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
Feb 1, 2022
This adds a missing _is_ in the readable.read() text and makes small style adjustments. PR-URL: #41524 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a missing is in the readable.read() text and makes
small style adjustments.