benchmark: remove input param manipulation #41741

MrJithil · 2022-01-29T05:53:10Z

Worked on a TODO which demands to avoid the manipulation of input param

benjamingr

Thanks 🙏

MrJithil · 2022-01-29T09:43:29Z

/test

benjamingr · 2022-01-29T09:47:00Z

@MrJithil there are two kinds of tests in Node:

There are tests that run on every PR automatically, you can see them under "checks".
There is a more extensive CI process which only collaborators can trigger due to risk potential.

I've gone ahead and added a label to this PR to automatically trigger CI :)

MrJithil · 2022-01-29T09:48:49Z

Thanks @benjamingr

Mesteery · 2022-01-29T09:51:46Z

request-ci will not launch or test this benchmark, or I am wrong? @benjamingr

benjamingr · 2022-01-29T10:07:54Z

Oh yeah, I'll start a benchmark run @Mesteery

Edit: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1091/

targos · 2022-01-29T10:40:11Z

There are some benchmark tests in CI. I don't know how the coverage for them is though.

Edit: Here https://github.com/nodejs/node/blob/master/test/benchmark/test-benchmark-assert.js

benjamingr · 2022-01-30T16:11:34Z

@Mesteery apparently the CI does test benchmarks, I didn't know that and @Trott showed me

nodejs-github-bot · 2022-01-30T16:12:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42245/

Trott · 2022-01-30T18:09:28Z

There are some benchmark tests in CI. I don't know how the coverage for them is though.

The coverage is minimal. Each benchmark file runs exactly one condition and that's it. The purpose is to make sure there aren't benchmarks that are completely broken and can't run at all. That used to happen.

nodejs-github-bot · 2022-01-31T07:59:45Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42259/

nodejs-github-bot · 2022-02-01T15:56:24Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42302/

nodejs-github-bot · 2022-02-01T18:07:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42304/

MrJithil · 2022-02-03T17:30:19Z

/request-ci

nodejs-github-bot · 2022-02-03T17:32:44Z

CI: https://ci.nodejs.org/job/node-test-pull-request/42335/

nodejs-github-bot · 2022-02-03T18:22:43Z

Commit Queue failed

- Loading data for nodejs/node/pull/41741
✔  Done loading data for nodejs/node/pull/41741
----------------------------------- PR info ------------------------------------
Title      benchmark: remove input param manipulation (#41741)
   ⚠  Could not retrieve the email or name of the PR author's from user's GitHub profile!
Branch     MrJithil:todo-task-4 -> nodejs:master
Labels     assert, test, benchmark, needs-ci
Commits    1
 - benchmark: avoid input param manipulation
Committers 1
 - MrJithil 
PR-URL: https://github.com/nodejs/node/pull/41741
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mary Marchini 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/41741
Reviewed-By: Benjamin Gruenbaum 
Reviewed-By: Mohammed Keyvanzadeh 
Reviewed-By: Mestery 
Reviewed-By: Luigi Pinca 
Reviewed-By: Colin Ihrig 
Reviewed-By: Mary Marchini 
--------------------------------------------------------------------------------
   ℹ  This PR was created on Sat, 29 Jan 2022 05:53:10 GMT
   ✔  Approvals: 6
   ✔  - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/41741#pullrequestreview-866902469
   ✔  - Mohammed Keyvanzadeh (@VoltrexMaster): https://github.com/nodejs/node/pull/41741#pullrequestreview-866928878
   ✔  - Mestery (@Mesteery): https://github.com/nodejs/node/pull/41741#pullrequestreview-866932788
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/41741#pullrequestreview-867009867
   ✔  - Colin Ihrig (@cjihrig) (TSC): https://github.com/nodejs/node/pull/41741#pullrequestreview-867200235
   ✔  - Mary Marchini (@mmarchini) (TSC): https://github.com/nodejs/node/pull/41741#pullrequestreview-867225186
   ✖  GitHub CI is still running
   ℹ  Last Full PR CI on 2022-02-03T17:32:44Z: https://ci.nodejs.org/job/node-test-pull-request/42335/
   ℹ  Last Benchmark CI on 2022-01-31T10:28:30Z: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/1091/
- Querying data for job/node-test-pull-request/42335/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu

https://github.com/nodejs/node/actions/runs/1791088414

Mesteery · 2022-02-03T18:24:28Z

I don't understand why one of the jobs is still marked as running on GitHub, while the same job is successful on Jenkins.

MrJithil · 2022-02-03T18:53:56Z

Help wanted on this

PR-URL: #41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

jasnell · 2022-02-05T16:26:50Z

Landed in 217acb9

PR-URL: #41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: nodejs#41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

PR-URL: #41741 Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Mestery <mestery@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Mary Marchini <oss@mmarchini.me> Reviewed-By: James M Snell <jasnell@gmail.com>

BridgeAR · 2023-02-07T15:36:31Z

I just noticed this and it seems like my comment was misunderstood :).

Any variable coming from the tests definition should be taken one by one instead of being changed inside of the method as the definition is printed as it is. If the method uses something else, the definition does not fit anymore.

n should be the number of runs. The reason for this was that it was not possible to define the defintion to keep the benchmark below a runtime threshold.

nodejs-github-bot added assert Issues and PRs related to the assert subsystem. benchmark Issues and PRs related to the benchmark subsystem. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Jan 29, 2022

MrJithil force-pushed the todo-task-4 branch from 2b6709c to 6876def Compare January 29, 2022 05:54

benjamingr approved these changes Jan 29, 2022

View reviewed changes

VoltrexKeyva approved these changes Jan 29, 2022

View reviewed changes

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2022

Mesteery approved these changes Jan 29, 2022

View reviewed changes

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 29, 2022

This comment has been minimized.

Sign in to view

benchmark: avoid input param manipulation

5fa6094

MrJithil force-pushed the todo-task-4 branch from 6876def to 5fa6094 Compare January 29, 2022 16:38

lpinca approved these changes Jan 29, 2022

View reviewed changes

github-actions bot mentioned this pull request Jan 30, 2022

CI Reliability 2022-01-30 nodejs/reliability#187

Open

25 tasks

Trott requested a review from BridgeAR January 30, 2022 03:24

cjihrig approved these changes Jan 30, 2022

View reviewed changes

This comment has been minimized.

Sign in to view

mmarchini approved these changes Jan 30, 2022

View reviewed changes

github-actions bot mentioned this pull request Jan 31, 2022

CI Reliability 2022-01-31 nodejs/reliability#188

Open

28 tasks

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Feb 1, 2022

This was referenced Feb 2, 2022

CI Reliability 2022-02-02 nodejs/reliability#190

Open

CI Reliability 2022-02-03 nodejs/reliability#191

Open

Mesteery added the commit-queue Add this label to land a pull request using GitHub Actions. label Feb 3, 2022

nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Feb 3, 2022

This was referenced Feb 4, 2022

CI Reliability 2022-02-04 nodejs/reliability#192

Open

CI Reliability 2022-02-05 nodejs/reliability#193

Open

jasnell approved these changes Feb 5, 2022

View reviewed changes

jasnell closed this Feb 5, 2022

github-actions bot mentioned this pull request Feb 6, 2022

CI Reliability 2022-02-06 nodejs/reliability#194

Open

27 tasks

ruyadorno mentioned this pull request Feb 8, 2022

v17.5.0 release proposal #41897

Merged

danielleadams mentioned this pull request Mar 3, 2022

v16.14.1 release proposal #42200

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

benchmark: remove input param manipulation #41741

benchmark: remove input param manipulation #41741

MrJithil commented Jan 29, 2022

benjamingr left a comment

MrJithil commented Jan 29, 2022

benjamingr commented Jan 29, 2022

MrJithil commented Jan 29, 2022

This comment has been minimized.

Mesteery commented Jan 29, 2022 •

edited

benjamingr commented Jan 29, 2022 •

edited

targos commented Jan 29, 2022 •

edited

benjamingr commented Jan 30, 2022

nodejs-github-bot commented Jan 30, 2022

Trott commented Jan 30, 2022

This comment has been minimized.

nodejs-github-bot commented Jan 31, 2022

nodejs-github-bot commented Feb 1, 2022

nodejs-github-bot commented Feb 1, 2022

MrJithil commented Feb 3, 2022

nodejs-github-bot commented Feb 3, 2022

nodejs-github-bot commented Feb 3, 2022

Mesteery commented Feb 3, 2022 •

edited

MrJithil commented Feb 3, 2022

jasnell commented Feb 5, 2022

BridgeAR commented Feb 7, 2023

benchmark: remove input param manipulation #41741

benchmark: remove input param manipulation #41741

Conversation

MrJithil commented Jan 29, 2022

benjamingr left a comment

Choose a reason for hiding this comment

MrJithil commented Jan 29, 2022

benjamingr commented Jan 29, 2022

MrJithil commented Jan 29, 2022

This comment has been minimized.

Mesteery commented Jan 29, 2022 • edited

benjamingr commented Jan 29, 2022 • edited

targos commented Jan 29, 2022 • edited

benjamingr commented Jan 30, 2022

nodejs-github-bot commented Jan 30, 2022

Trott commented Jan 30, 2022

This comment has been minimized.

nodejs-github-bot commented Jan 31, 2022

nodejs-github-bot commented Feb 1, 2022

nodejs-github-bot commented Feb 1, 2022

MrJithil commented Feb 3, 2022

nodejs-github-bot commented Feb 3, 2022

nodejs-github-bot commented Feb 3, 2022

Mesteery commented Feb 3, 2022 • edited

MrJithil commented Feb 3, 2022

jasnell commented Feb 5, 2022

BridgeAR commented Feb 7, 2023

Mesteery commented Jan 29, 2022 •

edited

benjamingr commented Jan 29, 2022 •

edited

targos commented Jan 29, 2022 •

edited

Mesteery commented Feb 3, 2022 •

edited