Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

benchmark: use Object.hasOwn() instead of hasOwnProperty() #41769

Merged
merged 1 commit into from Jan 31, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Jan 30, 2022

No description provided.

@nodejs-github-bot nodejs-github-bot added benchmark Issues and PRs related to the benchmark subsystem. http Issues or PRs related to the http subsystem. labels Jan 30, 2022
@Trott Trott added request-ci Add this label to start a Jenkins CI on a PR. and removed http Issues or PRs related to the http subsystem. benchmark Issues and PRs related to the benchmark subsystem. labels Jan 30, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Jan 30, 2022
@nodejs-github-bot

This comment has been minimized.

@Trott Trott added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. labels Jan 30, 2022
@github-actions
Copy link
Contributor

Fast-track has been requested by @Trott. Please 👍 to approve.

@benjamingr benjamingr added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Jan 30, 2022
@nodejs-github-bot
Copy link
Collaborator

@benjamingr
Copy link
Member

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)

@Trott
Copy link
Member Author

Trott commented Jan 30, 2022

(Ci doesn't test benchmarks so I assume this is to please commit-queue?)

CI does test benchmarks.

https://ci.nodejs.org/job/node-test-commit-linux/44499/nodes=ubuntu1804-64/console

06:46:50 ok 3382 benchmark/test-benchmark-assert
06:46:51   ---
06:46:51   duration_ms: 1.112
06:46:51   ...
06:46:51 ok 3383 benchmark/test-benchmark-async-hooks
06:46:52   ---
06:46:52   duration_ms: 0.910
06:46:52   ...
06:46:52 ok 3384 benchmark/test-benchmark-buffer
06:46:55   ---
06:46:55   duration_ms: 3.114

@nodejs-github-bot
Copy link
Collaborator

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 31, 2022
@nodejs-github-bot nodejs-github-bot merged commit 96e81df into nodejs:master Jan 31, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 96e81df

ruyadorno pushed a commit that referenced this pull request Feb 8, 2022
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 2, 2022
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 3, 2022
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
danielleadams pushed a commit that referenced this pull request Mar 14, 2022
PR-URL: #41769
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants