From 835d11c537ee7789512da02ea3dacfc3a592c0a9 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Mon, 14 Feb 2022 20:50:27 -0500 Subject: [PATCH 01/14] build: add action to close stale feature requests Implement the prodecure outlined in https://github.com/nodejs/node/blob/master/doc/contributing/feature-request-management.md Signed-off-by: Michael Dawson --- .../close-stale-feature-requests.yml | 43 +++++++++++++++++++ 1 file changed, 43 insertions(+) create mode 100644 .github/workflows/close-stale-feature-requests.yml diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml new file mode 100644 index 00000000000000..d2ce1786ddabc3 --- /dev/null +++ b/.github/workflows/close-stale-feature-requests.yml @@ -0,0 +1,43 @@ +name: Close stale feature requests +on: + schedule: + - cron: 0 1 * * * + +env: + CLOSE_MESSAGE: > + There has been no activity on this feature request + and it is being closed. We value your input + and if you feel closing this issue was not the + right thing to do, please re-open it. + + For more information on how the project manages + feature requests please consult the + [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). + + WARN_MESSAGE: > + There has been no activity on this feature request for + 5 months and it is unlikely to be implemented. + It will be closed after 6 months after the last non-automated comment + unless there is renewed discussion or collaborators advocating that + it be kept open. For more information on how the project manages + feature requests please consult the + [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). + +jobs: + stale: + if: github.repository == 'nodejs/node' + runs-on: ubuntu-latest + steps: + - uses: actions/stale@v4 + with: + repo-token: ${{ secrets.GITHUB_TOKEN }} + days-before-stale: 150 + days-before-close: 30 + stale-issue-label: stale + close-issue-message: ${{ env.CLOSE_MESSAGE }} + stale-issue-message: ${{ env.WARN_MESSAGE }} + only-labels: feature request + exempt-pr-labels: never-stale + # max requests it will send per run to the GitHub API before it deliberately exits to avoid hitting API rate limits + operations-per-run: 1 + remove-stale-when-updated: true From be436fa75ad34cb8df827449792b7c6f509f42c3 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:40:02 -0500 Subject: [PATCH 02/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Mestery --- .github/workflows/close-stale-feature-requests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index d2ce1786ddabc3..1a308f1e7e22ae 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -1,6 +1,7 @@ name: Close stale feature requests on: schedule: + # Run every day at 1:00 AM UTC. - cron: 0 1 * * * env: From 29b1c0fb993309bdb4acc816d65bb4f41aa3d8de Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:40:12 -0500 Subject: [PATCH 03/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 1a308f1e7e22ae..12cfc2451333ac 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -21,7 +21,7 @@ env: It will be closed after 6 months after the last non-automated comment unless there is renewed discussion or collaborators advocating that it be kept open. For more information on how the project manages - feature requests please consult the + feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). jobs: From b7b78be447d5233553692ac0444b8622beab7528 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:40:35 -0500 Subject: [PATCH 04/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 12cfc2451333ac..f03068b176a1eb 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -18,7 +18,7 @@ env: WARN_MESSAGE: > There has been no activity on this feature request for 5 months and it is unlikely to be implemented. - It will be closed after 6 months after the last non-automated comment + It will be closed 6 months after the last non-automated comment. unless there is renewed discussion or collaborators advocating that it be kept open. For more information on how the project manages feature requests, please consult the From 1447974b7e80680d6fd23b1b24a42b3d0440358f Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:40:40 -0500 Subject: [PATCH 05/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index f03068b176a1eb..208aa4a23c5e4b 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -19,8 +19,7 @@ env: There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. - unless there is renewed discussion or collaborators advocating that - it be kept open. For more information on how the project manages + For more information on how the project manages feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). From df3e9154ab2721a23ce9deeff08a033428276c0c Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:40:47 -0500 Subject: [PATCH 06/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 208aa4a23c5e4b..ddd23dd7ebf491 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -12,7 +12,7 @@ env: right thing to do, please re-open it. For more information on how the project manages - feature requests please consult the + feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). WARN_MESSAGE: > From 87cc1e564a85e7e63c79ad98f701e1de216a7a19 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:41:02 -0500 Subject: [PATCH 07/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index ddd23dd7ebf491..d835b80ddffbbe 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -9,7 +9,7 @@ env: There has been no activity on this feature request and it is being closed. We value your input and if you feel closing this issue was not the - right thing to do, please re-open it. + right thing to do, please leave a comment. For more information on how the project manages feature requests, please consult the From 4b1a3a0bdac8a7b0bcd4692010debf15be15ca40 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:41:10 -0500 Subject: [PATCH 08/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Rich Trott --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index d835b80ddffbbe..b3f4fe09f39ffe 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -8,7 +8,7 @@ env: CLOSE_MESSAGE: > There has been no activity on this feature request and it is being closed. We value your input - and if you feel closing this issue was not the + and if you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages From 2a1aea04689ca016c84616e6feda86e4b8ca3c9c Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:42:53 -0500 Subject: [PATCH 09/14] Update .github/workflows/close-stale-feature-requests.yml --- .github/workflows/close-stale-feature-requests.yml | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index b3f4fe09f39ffe..ce4b59e0350aff 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -7,8 +7,7 @@ on: env: CLOSE_MESSAGE: > There has been no activity on this feature request - and it is being closed. We value your input - and if you feel closing this issue is not the + and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. For more information on how the project manages From cb132c47adf288276f00d481ecff682cf2822dbd Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Tue, 15 Feb 2022 16:43:42 -0500 Subject: [PATCH 10/14] Update .github/workflows/close-stale-feature-requests.yml --- .github/workflows/close-stale-feature-requests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index ce4b59e0350aff..bb4cfa1c464577 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -18,6 +18,7 @@ env: There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. + For more information on how the project manages feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). From b85e753bf6933b3f267d0db40701913ed7cfac00 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Wed, 16 Feb 2022 09:16:09 -0500 Subject: [PATCH 11/14] Address linter complaints --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index bb4cfa1c464577..f2e5760f6296e8 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -18,7 +18,7 @@ env: There has been no activity on this feature request for 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. - + For more information on how the project manages feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). From a7bc6edd5d0ba0d378f8b91c54fedad3735dd79c Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 17 Feb 2022 10:57:47 -0500 Subject: [PATCH 12/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Mestery --- .github/workflows/close-stale-feature-requests.yml | 1 + 1 file changed, 1 insertion(+) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index f2e5760f6296e8..90d62d52f5a9c7 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -10,6 +10,7 @@ env: and it is being closed. If you feel closing this issue is not the right thing to do, please leave a comment. + For more information on how the project manages feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). From 31c99cbefc147cd54bd932198f9c994a978af4b3 Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 17 Feb 2022 10:57:55 -0500 Subject: [PATCH 13/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Antoine du Hamel --- .github/workflows/close-stale-feature-requests.yml | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 90d62d52f5a9c7..0a656f6d46635d 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -34,7 +34,7 @@ jobs: repo-token: ${{ secrets.GITHUB_TOKEN }} days-before-stale: 150 days-before-close: 30 - stale-issue-label: stale + stale-issue-label: stalled close-issue-message: ${{ env.CLOSE_MESSAGE }} stale-issue-message: ${{ env.WARN_MESSAGE }} only-labels: feature request From 729274ca8635e4fd7f3b344ab64fee45c2eb44cf Mon Sep 17 00:00:00 2001 From: Michael Dawson Date: Thu, 17 Feb 2022 13:58:02 -0500 Subject: [PATCH 14/14] Update .github/workflows/close-stale-feature-requests.yml Co-authored-by: Mestery --- .github/workflows/close-stale-feature-requests.yml | 3 +++ 1 file changed, 3 insertions(+) diff --git a/.github/workflows/close-stale-feature-requests.yml b/.github/workflows/close-stale-feature-requests.yml index 0a656f6d46635d..898dcbdecbb4b0 100644 --- a/.github/workflows/close-stale-feature-requests.yml +++ b/.github/workflows/close-stale-feature-requests.yml @@ -4,6 +4,7 @@ on: # Run every day at 1:00 AM UTC. - cron: 0 1 * * * +# yamllint disable rule:empty-lines env: CLOSE_MESSAGE: > There has been no activity on this feature request @@ -20,9 +21,11 @@ env: 5 months and it is unlikely to be implemented. It will be closed 6 months after the last non-automated comment. + For more information on how the project manages feature requests, please consult the [feature request management document](https://github.com/nodejs/node/blob/HEAD/doc/guides/feature-request-management.md). +# yamllint enable jobs: stale: