src,inspector: fix empty MaybeLocal crash #42409
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: nodejs#42407 Signed-off-by: Darshan Sen <raisinten@gmail.com>
nodejs-github-bot
added
c++
This comment was marked as outdated.
This comment was marked as outdated.
richardlau
approved these changes
Mar 20, 2022
RaisinTen
added
the
author ready
VoltrexKeyva
approved these changes
Mar 20, 2022
addaleax
approved these changes
Mar 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
tniessen
approved these changes
Mar 20, 2022
This comment was marked as outdated.
This comment was marked as outdated.
37 tasks
This comment was marked as outdated.
This comment was marked as outdated.
juanarbol
approved these changes
Mar 21, 2022
32 tasks
This comment was marked as outdated.
This comment was marked as outdated.
28 tasks
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This was referenced Mar 24, 2022
jasnell
approved these changes
Mar 25, 2022
26 tasks
This comment was marked as outdated.
This comment was marked as outdated.
26 tasks
Signed-off-by: Darshan Sen <raisinten@gmail.com>
|
The test was failing due to a timeout on node-test-binary-arm-12+ and node-test-commit-custom-suites-freestyle (test-worker), so I have marked it as slow, PTAL. |
Signed-off-by: Darshan Sen <raisinten@gmail.com>
This comment was marked as outdated.
This comment was marked as outdated.
@richardlau Done, PTAL. I guess you would need to update #42645 if this one lands first. |
richardlau
approved these changes
Apr 8, 2022
RaisinTen
added
the
author ready
|
@richardlau node-test-commit-freebsd too seems to have failed with the same EDIT: yea, rerunning helped, landing! |
24 tasks
RaisinTen
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in be01185 |
This was referenced Apr 10, 2022
29 tasks
|
The problem doesn't seem completely fixed. New test crashes sometimes on freebsd: |
xtx1130
pushed a commit
to xtx1130/node
that referenced
this pull request
Apr 25, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: nodejs#42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42409 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Dossar
pushed a commit
to Dossar/node
that referenced
this pull request
May 26, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: nodejs#42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: nodejs#42409 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
May 31, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport--PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
juanarbol
pushed a commit
that referenced
this pull request
Jun 1, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport-PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Merged
BethGriggs
pushed a commit
that referenced
this pull request
Jun 1, 2022
Return early when the Inspector StringView to V8 String conversion fails and returns an empty MaybeLocal instead of running the invalid ToLocalChecked() assertion. Fixes: #42407 Signed-off-by: Darshan Sen <raisinten@gmail.com> PR-URL: #42409 Backport-PR-URL: #42967 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
I experience this with Node v18.18.2
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Return early when the Inspector StringView to V8 String conversion fails
and returns an empty MaybeLocal instead of running the invalid
ToLocalChecked() assertion.
Fixes: #42407
Signed-off-by: Darshan Sen raisinten@gmail.com