From a806586b273239629ba4e536637018fd09c48246 Mon Sep 17 00:00:00 2001 From: MURAKAMI Masahiko Date: Mon, 11 Apr 2022 09:15:17 +0900 Subject: [PATCH 1/3] test: improve lib/readline.js coverage --- test/parallel/test-readline-interface.js | 14 ++++++++++++++ 1 file changed, 14 insertions(+) diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js index ba72d282ea6d8e..956df9ea64e6e4 100644 --- a/test/parallel/test-readline-interface.js +++ b/test/parallel/test-readline-interface.js @@ -71,6 +71,20 @@ function assertCursorRowsAndCols(rli, rows, cols) { assert(rl instanceof readline.Interface); } +{ + const fi = new FakeInput(); + const completer = (line) => [[], line]; + const rli = new readline.Interface( + fi, + fi, + common.mustCallAtLeast(completer), + true, + ); + assert(rli instanceof readline.Interface); + fi.emit('data', 'a\t'); + rli.close(); +} + [ undefined, 50, From 89f547bb02b5be76909ebb4f909a7ea29724bfd5 Mon Sep 17 00:00:00 2001 From: MURAKAMI Masahiko Date: Mon, 11 Apr 2022 09:27:47 +0900 Subject: [PATCH 2/3] test: inlining completer function --- test/parallel/test-readline-interface.js | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js index 956df9ea64e6e4..27a3dba5a701d7 100644 --- a/test/parallel/test-readline-interface.js +++ b/test/parallel/test-readline-interface.js @@ -73,11 +73,10 @@ function assertCursorRowsAndCols(rli, rows, cols) { { const fi = new FakeInput(); - const completer = (line) => [[], line]; const rli = new readline.Interface( fi, fi, - common.mustCallAtLeast(completer), + common.mustCallAtLeast((line) => [[], line]), true, ); assert(rli instanceof readline.Interface); From eddab0169d54f10261f9ee62d73790043903d1e9 Mon Sep 17 00:00:00 2001 From: MURAKAMI Masahiko Date: Mon, 11 Apr 2022 15:30:16 +0900 Subject: [PATCH 3/3] test: use `mustCall` instead of `mustCallAtLeast` --- test/parallel/test-readline-interface.js | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/parallel/test-readline-interface.js b/test/parallel/test-readline-interface.js index 27a3dba5a701d7..7bffa0b66e5cf8 100644 --- a/test/parallel/test-readline-interface.js +++ b/test/parallel/test-readline-interface.js @@ -76,7 +76,7 @@ function assertCursorRowsAndCols(rli, rows, cols) { const rli = new readline.Interface( fi, fi, - common.mustCallAtLeast((line) => [[], line]), + common.mustCall((line) => [[], line]), true, ); assert(rli instanceof readline.Interface);