Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[v14.x] doc: specify flag needed for JSON modules #42736

Closed
wants to merge 1 commit into from

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 14, 2022

No description provided.

@nodejs-github-bot
Copy link
Collaborator

Review requested:

  • @nodejs/modules

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation. v14.x labels Apr 14, 2022
@Trott
Copy link
Member Author

Trott commented Apr 14, 2022

I'm opening this against v14.x-staging because the flag is not required in 17.x.

@aduh95 aduh95 changed the title doc: specify flag needed for JSON modules [v14.x] doc: specify flag needed for JSON modules Apr 14, 2022
doc/api/esm.md Outdated Show resolved Hide resolved
doc/api/esm.md Outdated Show resolved Hide resolved
juanarbol pushed a commit that referenced this pull request Apr 28, 2022
PR-URL: #42736
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@juanarbol
Copy link
Member

juanarbol commented Apr 28, 2022

Thanksss!

Landed in 3d3d7ed 🎉

@juanarbol juanarbol closed this Apr 28, 2022
@juanarbol juanarbol mentioned this pull request Apr 28, 2022
juanarbol pushed a commit that referenced this pull request May 1, 2022
PR-URL: #42736
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>
@Trott Trott deleted the v14.x-esm branch September 25, 2022 17:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. esm Issues and PRs related to the ECMAScript Modules implementation.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants