stream: handle enqueuing chunks when a pending BYOB pull request exists #44770
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
/cc @nodejs/whatwg-stream |
daeyeon
force-pushed
the
main.rbstream-enqueue-220925.Sun.c9a6
branch
from
d172d2c
to
f4bb2a9
Compare
benjamingr
approved these changes
Sep 25, 2022
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com>
daeyeon
force-pushed
the
main.rbstream-enqueue-220925.Sun.c9a6
branch
from
f4bb2a9
to
3c6b203
Compare
|
Rebased to apply the fix for |
daeyeon
added
request-ci
github-actions
bot
removed
the
request-ci
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
This comment was marked as outdated.
14 tasks
This was referenced Sep 28, 2022
daeyeon
added
the
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44770 ✔ Done loading data for nodejs/node/pull/44770 ----------------------------------- PR info ------------------------------------ Title stream: handle enqueuing chunks when a pending BYOB pull request exists (#44770) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch daeyeon:main.rbstream-enqueue-220925.Sun.c9a6 -> nodejs:main Labels author ready, needs-ci, web streams Commits 1 - stream: handle enqueuing chunks when a pending BYOB pull request exists Committers 1 - Daeyeon Jeong PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: handle enqueuing chunks when a pending BYOB pull request exists ℹ This PR was created on Sat, 24 Sep 2022 16:08:15 GMT ✔ Approvals: 1 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/44770#pullrequestreview-1119407923 ✖ This PR needs to wait 28 more hours to land (or 0 hours if there is one more approval) ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-27T06:52:34Z: https://ci.nodejs.org/job/node-test-pull-request/46854/ - Querying data for job/node-test-pull-request/46854/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3158324345 |
daeyeon
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44770 ✔ Done loading data for nodejs/node/pull/44770 ----------------------------------- PR info ------------------------------------ Title stream: handle enqueuing chunks when a pending BYOB pull request exists (#44770) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch daeyeon:main.rbstream-enqueue-220925.Sun.c9a6 -> nodejs:main Labels author ready, needs-ci, web streams Commits 1 - stream: handle enqueuing chunks when a pending BYOB pull request exists Committers 1 - Daeyeon Jeong PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: handle enqueuing chunks when a pending BYOB pull request exists ℹ This PR was created on Sat, 24 Sep 2022 16:08:15 GMT ✔ Approvals: 1 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/44770#pullrequestreview-1119407923 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-09-30T11:15:31Z: https://ci.nodejs.org/job/node-test-pull-request/46854/ - Querying data for job/node-test-pull-request/46854/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3167117966 |
daeyeon
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
nodejs-github-bot
added
the
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44770 ✔ Done loading data for nodejs/node/pull/44770 ----------------------------------- PR info ------------------------------------ Title stream: handle enqueuing chunks when a pending BYOB pull request exists (#44770) ⚠ Could not retrieve the email or name of the PR author's from user's GitHub profile! Branch daeyeon:main.rbstream-enqueue-220925.Sun.c9a6 -> nodejs:main Labels author ready, needs-ci, web streams Commits 1 - stream: handle enqueuing chunks when a pending BYOB pull request exists Committers 1 - Daeyeon Jeong PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum -------------------------------------------------------------------------------- ⚠ Commits were pushed since the last review: ⚠ - stream: handle enqueuing chunks when a pending BYOB pull request exists ℹ This PR was created on Sat, 24 Sep 2022 16:08:15 GMT ✔ Approvals: 1 ✔ - Benjamin Gruenbaum (@benjamingr): https://github.com/nodejs/node/pull/44770#pullrequestreview-1119407923 ✔ Last GitHub CI successful ℹ Last Full PR CI on 2022-10-02T03:14:39Z: https://ci.nodejs.org/job/node-test-pull-request/46854/ - Querying data for job/node-test-pull-request/46854/ ✔ Last Jenkins CI successful -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3167235974 |
mcollina
added
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 43e2f60 |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Signed-off-by: Daeyeon Jeong <daeyeon.dev@gmail.com> PR-URL: #44770 Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles enqueuing chunks when there is a pending BYOB pull request demanded from a released reader.
Refs: https://streams.spec.whatwg.org/#readable-byte-stream-controller-enqueue (step 8,9)
Signed-off-by: Daeyeon Jeong daeyeon.dev@gmail.com