doc: move release keys we don't use anymore in README #44899
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@nodejs/releasers |
Trott
added
fast-track
|
Fast-track has been requested by @Trott. Please 👍 to approve. |
Trott
added a commit
to nodejs/docker-node
that referenced
this pull request
Oct 6, 2022
richardlau
approved these changes
Oct 6, 2022
targos
approved these changes
Oct 6, 2022
lpinca
approved these changes
Oct 6, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
Commit Queue failed- Loading data for nodejs/node/pull/44899 ✔ Done loading data for nodejs/node/pull/44899 ----------------------------------- PR info ------------------------------------ Title doc: move release keys we don't use anymore in README (#44899) Author Rich Trott (@Trott) Branch Trott:releasers -> nodejs:main Labels fast-track Commits 2 - doc: move release keys we don't use anymore in README - fixup! doc: move release keys we don't use anymore in README Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/44899 Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers Refs: https://github.com/nodejs/Release/pull/784 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44899 Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers Refs: https://github.com/nodejs/Release/pull/784 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Oct 2022 00:23:20 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3200609475 |
nodejs-github-bot
added
the
commit-queue-failed
Trott
added
commit-queue
nodejs-github-bot
added
commit-queue-failed
Commit Queue failed- Loading data for nodejs/node/pull/44899 ✔ Done loading data for nodejs/node/pull/44899 ----------------------------------- PR info ------------------------------------ Title doc: move release keys we don't use anymore in README (#44899) Author Rich Trott (@Trott) Branch Trott:releasers -> nodejs:main Labels fast-track, commit-queue-squash Commits 2 - doc: move release keys we don't use anymore in README - fixup! doc: move release keys we don't use anymore in README Committers 1 - Rich Trott PR-URL: https://github.com/nodejs/node/pull/44899 Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers Refs: https://github.com/nodejs/Release/pull/784 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca ------------------------------ Generated metadata ------------------------------ PR-URL: https://github.com/nodejs/node/pull/44899 Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers Refs: https://github.com/nodejs/Release/pull/784 Reviewed-By: Richard Lau Reviewed-By: Michaël Zasso Reviewed-By: Luigi Pinca -------------------------------------------------------------------------------- ℹ This PR was created on Thu, 06 Oct 2022 00:23:20 GMT ✔ Approvals: 3 ✔ - Richard Lau (@richardlau) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1132195873 ✔ - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133136782 ✔ - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/44899#pullrequestreview-1133500155 ℹ This PR is being fast-tracked ✖ The fast-track request requires at least two collaborators' approvals (👍). ✔ Last GitHub CI successful ℹ Green GitHub CI is sufficient -------------------------------------------------------------------------------- ✔ Aborted `git node land` session in /home/runner/work/node/node/.ncuhttps://github.com/nodejs/node/actions/runs/3200661575 |
Trott
removed
the
commit-queue-failed
tniessen
approved these changes
Oct 7, 2022
marsonya
approved these changes
Oct 7, 2022
Trott
added
the
commit-queue
nodejs-github-bot
removed
the
commit-queue
|
Landed in 24d255f |
danielleadams
pushed a commit
that referenced
this pull request
Oct 11, 2022
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers Refs: nodejs/Release#784 PR-URL: #44899 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Akhil Marsonya <akhil.marsonya27@gmail.com>
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Refs: https://github.com/nodejs/Release/blob/3cd3c6a65188d0e64017d0cee11b9834a5753fd5/GOVERNANCE.md#offboarding-releasers
Refs: nodejs/Release#784