Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: update eslint to 8.25.0 #44931

Merged
merged 1 commit into from Oct 9, 2022
Merged

tools: update eslint to 8.25.0 #44931

merged 1 commit into from Oct 9, 2022

Conversation

nodejs-github-bot
Copy link
Collaborator

This is an automated update of eslint to 8.25.0.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Oct 9, 2022
@Trott Trott added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2022
Trott
Trott approved these changes Oct 9, 2022
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 9, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Oct 9, 2022

Fast-track has been requested by @Trott. Please 👍 to approve.

@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 9, 2022
@nodejs-github-bot
Copy link
Collaborator Author

CI: https://ci.nodejs.org/job/node-test-pull-request/47130/

@Trott Trott added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 9, 2022
@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit 6a57796 into main Oct 9, 2022
@nodejs-github-bot
Copy link
Collaborator Author

Landed in 6a57796

@nodejs-github-bot nodejs-github-bot deleted the actions/tools-update-eslint branch October 9, 2022 06:02
danielleadams pushed a commit that referenced this pull request Oct 11, 2022
@nodejs-github-bot @danielleadams
tools: update eslint to 8.25.0
ad8b8ae 
PR-URL: #44931
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@danielleadams danielleadams mentioned this pull request Oct 11, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@lpinca lpinca lpinca approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. tools Issues and PRs related to the tools directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@nodejs-github-bot @Trott @lpinca