deps: update V8 to 10.8 #45230

targos · 2022-10-29T09:43:32Z

Stable Release:
Tue, Nov 29, 2022

nodejs-github-bot · 2022-10-29T09:43:36Z

Review requested:

@nodejs/gyp
@nodejs/v8-update

targos · 2022-10-31T10:49:24Z

There's also a failure with test-trace-gc-flag

12:10:45 not ok 1 v8-updates/test-trace-gc-flag
12:10:45   ---
12:10:45   duration_ms: 0.348
12:10:45   severity: fail
12:10:45   exitcode: 1
12:10:45   stack: |-
12:10:45     node:assert:1027
12:10:45         throw err;
12:10:45         ^
12:10:45     
12:10:45     AssertionError [ERR_ASSERTION]: The input did not match the regular expression /\bMark-sweep\b/. Input:
12:10:45     
12:10:45     '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested'
12:10:45     
12:10:45         at /home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:30:12
12:10:45         at Array.forEach (<anonymous>)
12:10:45         at Object.<anonymous> (/home/iojs/build/workspace/node-test-commit-v8-linux/test/v8-updates/test-trace-gc-flag.js:29:9)
12:10:45         at Module._compile (node:internal/modules/cjs/loader:1175:14)
12:10:45         at Module._extensions..js (node:internal/modules/cjs/loader:1229:10)
12:10:45         at Module.load (node:internal/modules/cjs/loader:1038:32)
12:10:45         at Module._load (node:internal/modules/cjs/loader:879:12)
12:10:45         at Function.executeUserEntryPoint [as runMain] (node:internal/modules/run_main:82:12)
12:10:45         at node:internal/main/run_main_module:23:47 {
12:10:45       generatedMessage: true,
12:10:45       code: 'ERR_ASSERTION',
12:10:45       actual: '[41903:0x55803f320350]       93 ms: Mark-Compact 11.8 (18.1) -> 4.3 (14.1) MB, 4.3 / 0.0 ms  (average mu = 1.000, current mu = 1.000) testing; GC in old space requested',
12:10:45       expected: /\bMark-sweep\b/,
12:10:45       operator: 'match'
12:10:45     }
12:10:45     
12:10:45     Node.js v20.0.0-pre
12:10:45   ...

/cc @tony-go

targos · 2022-10-31T13:15:26Z

@nodejs/platform-windows

x86 build fails on Windows:

12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(344,35): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\spaces.h(345,28): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]
12:15:17 C:\workspace\node-compile-windows\node\deps\v8\src\heap\large-spaces.h(59,33): error C2607: static assertion failed [C:\workspace\node-compile-windows\node\tools\v8_gypfiles\v8_init.vcxproj]

StefanStojanovic · 2022-11-02T14:38:04Z

Hello, @targos. All failing asserts are manifestations of the same issue - MemoryChunkLayout::kMemoryChunkHeaderSize not being set to the correct value. I've found this commit in the v8 repo that fixes the problem. I've tried it locally and the build passes.

targos · 2022-11-02T14:50:32Z

@StefanStojanovic thanks! I'll cherry-pick that commit

nodejs-github-bot · 2022-11-05T09:14:06Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47713/

nodejs-github-bot · 2022-11-05T09:15:16Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-s390x,v8test=v8test/4961/

nodejs-github-bot · 2022-11-05T09:19:17Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=rhel8-ppc64le,v8test=v8test/4961/

nodejs-github-bot · 2022-11-05T09:43:24Z

V8 CI: https://ci.nodejs.org/job/node-test-commit-v8-linux/nodes=benchmark-ubuntu1804-intel-64,v8test=v8test/4961/

Refs: https://bugs.chromium.org/p/v8/issues/detail?id=12661 Refs: nodejs#42375 PR-URL: nodejs#42657 Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#44741 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [heap] Fix 32bit msvc builds Size of ActiveSystemPages is 8 bytes even on 32bit builds, thus forcing 8 bytes alignment for MemoryChunk. Change-Id: I5ca1e18329d6e68a8b6811c3c27cb224c765cb63 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3966953 Commit-Queue: Omer Katz <omerkatz@chromium.org> Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Cr-Commit-Position: refs/heads/main@{#83845} Refs: v8/v8@92a7385 PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: nodejs/node-v8#239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: v8/v8@f1c888e PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Original commit message: Add an `v8::ArrayBuffer::WasDetached` method to the C++ API V8's C++ API does not give a way to tell whether an ArrayBuffer has been detached from the `v8::ArrayBuffer` class. In fact, as far as can be told from the C++ API without running JS code, detached ArrayBuffers behave the same as zero-sized ArrayBuffers and there is no way to observe the difference. However, this difference can be observed in JS because constructing a TypedArray from a detached ArrayBuffer will throw. This change adds a `WasDetached` method to the `v8::ArrayBuffer` class to give embedders access to this information without having to run JS code. Bug: v8:13159 Change-Id: I2bb1e380cee1cecd31f6d48ec3d9f28c03a8a673 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/3810345 Commit-Queue: Toon Verwaest <verwaest@chromium.org> Reviewed-by: Toon Verwaest <verwaest@chromium.org> Cr-Commit-Position: refs/heads/main@{#83963} Refs: v8/v8@9df5ef7 PR-URL: nodejs#45474 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Daeyeon Jeong <daeyeon.dev@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> PR-URL: nodejs#45230 Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 deps: * update V8 to 10.8.168.20 (Michaël Zasso) #45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 PR-URL: TBD

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 deps: * update V8 to 10.8.168.20 (Michaël Zasso) #45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 PR-URL: #45615

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 deps: * update timezone to 2022f (Node.js GitHub Bot) #45289 * update V8 to 10.8.168.20 (Michaël Zasso) #45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 PR-URL: #45615

Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: nodejs/node-v8#239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: v8/v8@f1c888e PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> # Conflicts: # common.gypi

Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: nodejs/node-v8#239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: v8/v8@f1c888e PR-URL: #45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> # Conflicts: # common.gypi PR-URL: #45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) #45139 deps: * update timezone to 2022f (Node.js GitHub Bot) #45289 * update V8 to 10.8.168.20 (Michaël Zasso) #45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) #45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) #45412 PR-URL: #45615

Original commit message: [base] Fix SmartOS build That platform doesn't have `malloc_usable_size`. Refs: nodejs/node-v8#239 Change-Id: I011dd8449d02b27219a32cba00132cd068069f50 Reviewed-on: https://chromium-review.googlesource.com/c/v8/v8/+/4026402 Reviewed-by: Michael Lippautz <mlippautz@chromium.org> Commit-Queue: Michaël Zasso <mic.besace@gmail.com> Cr-Commit-Position: refs/heads/main@{#84256} Refs: v8/v8@f1c888e PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> # Conflicts: # common.gypi PR-URL: nodejs#45579 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>

Notable changes: buffer: * (SEMVER-MINOR) introduce File (Khafra) nodejs#45139 deps: * update timezone to 2022f (Node.js GitHub Bot) nodejs#45289 * update V8 to 10.8.168.20 (Michaël Zasso) nodejs#45230 doc: * deprecate use of invalid ports in `url.parse` (Antoine du Hamel) nodejs#45576 util: * add fast path for utf8 encoding (Yagiz Nizipli) nodejs#45412 PR-URL: nodejs#45615

nodejs/node#45230

* chore: upgrade to Node.js v20 * src: allow embedders to override NODE_MODULE_VERSION nodejs/node#49279 * src: fix missing trailing , nodejs/node#46909 * src,tools: initialize cppgc nodejs/node#45704 * tools: allow passing absolute path of config.gypi in js2c nodejs/node#49162 * tools: port js2c.py to C++ nodejs/node#46997 * doc,lib: disambiguate the old term, NativeModule nodejs/node#45673 * chore: fixup Node.js BSSL tests * nodejs/node#49492 * nodejs/node#44498 * deps: upgrade to libuv 1.45.0 nodejs/node#48078 * deps: update V8 to 10.7 nodejs/node#44741 * test: use gcUntil() in test-v8-serialize-leak nodejs/node#49168 * module: make CJS load from ESM loader nodejs/node#47999 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * chore: address changes to CJS/ESM loading * module: make CJS load from ESM loader (nodejs/node#47999) * lib: improve esm resolve performance (nodejs/node#46652) * bootstrap: optimize modules loaded in the built-in snapshot nodejs/node#45849 * test: mark test-runner-output as flaky nodejs/node#49854 * lib: lazy-load deps in modules/run_main.js nodejs/node#45849 * url: use private properties for brand check nodejs/node#46904 * test: refactor `test-node-output-errors` nodejs/node#48992 * assert: deprecate callTracker nodejs/node#47740 * src: cast v8::Object::GetInternalField() return value to v8::Value nodejs/node#48943 * test: adapt test-v8-stats for V8 update nodejs/node#45230 * tls: ensure TLS Sockets are closed if the underlying wrap closes nodejs/node#49327 * test: deflake test-tls-socket-close nodejs/node#49575 * net: fix crash due to simultaneous close/shutdown on JS Stream Sockets nodejs/node#49400 * net: use asserts in JS Socket Stream to catch races in future nodejs/node#49400 * lib: fix BroadcastChannel initialization location nodejs/node#46864 * src: create BaseObject with node::Realm nodejs/node#44348 * src: implement DataQueue and non-memory resident Blob nodejs/node#45258 * sea: add support for V8 bytecode-only caching nodejs/node#48191 * chore: fixup patch indices * gyp: put filenames in variables nodejs/node#46965 * build: modify js2c.py into GN executable * fix: (WIP) handle string replacement of fs -> original-fs * [v20.x] backport vm-related memory fixes nodejs/node#49874 * src: make BuiltinLoader threadsafe and non-global nodejs/node#45942 * src: avoid copying string in fs_permission nodejs/node#47746 * look upon my works ye mighty and dispair * chore: patch cleanup * [api] Remove AllCan Read/Write https://chromium-review.googlesource.com/c/v8/v8/+/5006387 * fix: missing include for NODE_EXTERN * chore: fixup patch indices * fix: fail properly when js2c fails in Node.js * build: fix js2c root_gen_dir * fix: lib/fs.js -> lib/original-fs.js * build: fix original-fs file xforms * fixup! module: make CJS load from ESM loader * build: get rid of CppHeap for now * build: add patch to prevent extra fs lookup on esm load * build: greatly simplify js2c modifications Moves our original-fs modifications back into a super simple python script action, wires up the output of that action into our call to js2c * chore: update to handle moved internal/modules/helpers file * test: update @types/node test * feat: enable preventing cppgc heap creation * feat: optionally prevent calling V8::EnableWebAssemblyTrapHandler * fix: no cppgc initialization in the renderer * gyp: put filenames in variables nodejs/node#46965 * test: disable single executable tests * fix: nan tests failing on node headers missing file * tls,http2: send fatal alert on ALPN mismatch nodejs/node#44031 * test: disable snapshot tests * nodejs/node#47887 * nodejs/node#49684 * nodejs/node#44193 * build: use deps/v8 for v8/tools Node.js hard depends on these in their builtins * test: fix edge snapshot stack traces nodejs/node#49659 * build: remove js2c //base dep * build: use electron_js2c_toolchain to build node_js2c * fix: don't create SafeSet outside packageResolve Fixes failure in parallel/test-require-delete-array-iterator: === release test-require-delete-array-iterator === Path: parallel/test-require-delete-array-iterator node:internal/per_context/primordials:426 constructor(i) { super(i); } // eslint-disable-line no-useless-constructor ^ TypeError: object is not iterable (cannot read property Symbol(Symbol.iterator)) at new Set (<anonymous>) at new SafeSet (node:internal/per_context/primordials:426:22) * fix: failing crashReporter tests on Linux These were failing because our change from node::InitializeNodeWithArgs to node::InitializeOncePerProcess meant that we now inadvertently called PlatformInit, which reset signal handling. This meant that our intentional crash function ElectronBindings::Crash no longer worked and the renderer process no longer crashed when process.crash() was called. We don't want to use Node.js' default signal handling in the renderer process, so we disable it by passing kNoDefaultSignalHandling to node::InitializeOncePerProcess. * build: only create cppgc heap on non-32 bit platforms * chore: clean up util:CompileAndCall * src: fix compatility with upcoming V8 12.1 APIs nodejs/node#50709 * fix: use thread_local BuiltinLoader * chore: fixup v8 patch indices --------- Co-authored-by: Keeley Hammond <vertedinde@electronjs.org> Co-authored-by: Samuel Attard <marshallofsound@electronjs.org>

nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. v8 engine Issues and PRs related to the V8 dependency. labels Oct 29, 2022

targos added dont-land-on-v14.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 29, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 29, 2022

This comment was marked as outdated.

Sign in to view

This comment was marked as resolved.

Sign in to view

This was referenced Oct 30, 2022

CI Reliability 2022-10-30 nodejs/reliability#415

Open

CI Reliability 2022-10-31 nodejs/reliability#416

Open

This was referenced Nov 1, 2022

CI Reliability 2022-11-01 nodejs/reliability#417

Open

CI Reliability 2022-11-02 nodejs/reliability#418

Open

targos force-pushed the v8-108 branch from b0f077c to 9608083 Compare November 5, 2022 09:10

This was referenced Nov 6, 2022

CI Reliability 2022-11-06 nodejs/reliability#420

Open

CI Reliability 2022-11-07 nodejs/reliability#421

Open

CI Reliability 2022-11-08 nodejs/reliability#422

Open

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022

test: adapt test-v8-stats for V8 update

cd01539

PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

marco-ippolito pushed a commit to marco-ippolito/node that referenced this pull request Nov 23, 2022

test: fix test-trace-gc-flag

aa8a863

PR-URL: nodejs#45230 Reviewed-By: Jiawen Geng <technicalcute@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>

ruyadorno mentioned this pull request Nov 24, 2022

v19.2.0 proposal #45615

Merged

gengjiawen mentioned this pull request Feb 1, 2023

deps: update V8 to 11.1 #46445

Closed

AdamMajer mentioned this pull request Mar 13, 2023

s390x: illegal instruction in unit tests #47064

Closed

codebytere added a commit to electron/electron that referenced this pull request Nov 6, 2023

test: adapt test-v8-stats for V8 update

345bcf1

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 14, 2023

test: adapt test-v8-stats for V8 update

32844f1

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 15, 2023

test: adapt test-v8-stats for V8 update

a48378a

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 16, 2023

test: adapt test-v8-stats for V8 update

be8fda1

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 21, 2023

test: adapt test-v8-stats for V8 update

c8f9106

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 22, 2023

test: adapt test-v8-stats for V8 update

47e8699

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 28, 2023

test: adapt test-v8-stats for V8 update

b15bac9

nodejs/node#45230

codebytere added a commit to electron/electron that referenced this pull request Nov 29, 2023

test: adapt test-v8-stats for V8 update

a41152f

nodejs/node#45230

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

deps: update V8 to 10.8 #45230

deps: update V8 to 10.8 #45230

targos commented Oct 29, 2022 •

edited

nodejs-github-bot commented Oct 29, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

targos commented Oct 31, 2022

targos commented Oct 31, 2022 •

edited

StefanStojanovic commented Nov 2, 2022

targos commented Nov 2, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

deps: update V8 to 10.8 #45230

deps: update V8 to 10.8 #45230

Conversation

targos commented Oct 29, 2022 • edited

nodejs-github-bot commented Oct 29, 2022

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as outdated.

This comment was marked as resolved.

targos commented Oct 31, 2022

targos commented Oct 31, 2022 • edited

StefanStojanovic commented Nov 2, 2022

targos commented Nov 2, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

nodejs-github-bot commented Nov 5, 2022

targos commented Oct 29, 2022 •

edited

targos commented Oct 31, 2022 •

edited