Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: improve test coverage for WHATWG TextDecoder #45241

Merged
merged 1 commit into from Jan 18, 2023

Conversation

juanarbol
Copy link
Member

Signed-off-by: Juan José Arboleda soyjuanarbol@gmail.com

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Oct 30, 2022
@nodejs-github-bot
Copy link
Collaborator

Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
@juanarbol juanarbol added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 8, 2022
@nodejs-github-bot
Copy link
Collaborator

@juanarbol juanarbol added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 9, 2022
@nodejs-github-bot nodejs-github-bot added commit-queue-failed An error occurred while landing this pull request using GitHub Actions. and removed commit-queue Add this label to land a pull request using GitHub Actions. labels Nov 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Commit Queue failed
- Loading data for nodejs/node/pull/45241
✔  Done loading data for nodejs/node/pull/45241
----------------------------------- PR info ------------------------------------
Title      test: improve test coverage for WHATWG `TextDecoder` (#45241)
Author     Juan José  (@juanarbol)
Branch     juanarbol:juan/coverage-text-decoder -> nodejs:main
Labels     test, needs-ci
Commits    1
 - test: improve test coverage for WHATWG `TextDecoder`
Committers 1
 - Juan José Arboleda 
PR-URL: https://github.com/nodejs/node/pull/45241
Reviewed-By: Michaël Zasso 
Reviewed-By: Darshan Sen 
Reviewed-By: Luigi Pinca 
------------------------------ Generated metadata ------------------------------
PR-URL: https://github.com/nodejs/node/pull/45241
Reviewed-By: Michaël Zasso 
Reviewed-By: Darshan Sen 
Reviewed-By: Luigi Pinca 
--------------------------------------------------------------------------------
   ⚠  Commits were pushed since the last review:
   ⚠  - test: improve test coverage for WHATWG `TextDecoder`
   ℹ  This PR was created on Sun, 30 Oct 2022 05:29:47 GMT
   ✔  Approvals: 3
   ✔  - Michaël Zasso (@targos) (TSC): https://github.com/nodejs/node/pull/45241#pullrequestreview-1161065185
   ✔  - Darshan Sen (@RaisinTen) (TSC): https://github.com/nodejs/node/pull/45241#pullrequestreview-1161328552
   ✔  - Luigi Pinca (@lpinca): https://github.com/nodejs/node/pull/45241#pullrequestreview-1163985761
   ✖  Last GitHub CI failed
   ℹ  Last Full PR CI on 2022-11-08T19:24:23Z: https://ci.nodejs.org/job/node-test-pull-request/47793/
- Querying data for job/node-test-pull-request/47793/
   ✔  Last Jenkins CI successful
--------------------------------------------------------------------------------
   ✔  Aborted `git node land` session in /home/runner/work/node/node/.ncu
https://github.com/nodejs/node/actions/runs/3431474431

@juanarbol
Copy link
Member Author

Is this ok to land? It looks like test-macOS timeout, but CI is green.

@lpinca lpinca added commit-queue Add this label to land a pull request using GitHub Actions. and removed commit-queue-failed An error occurred while landing this pull request using GitHub Actions. labels Jan 18, 2023
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Jan 18, 2023
@nodejs-github-bot nodejs-github-bot merged commit 5d56097 into nodejs:main Jan 18, 2023
@nodejs-github-bot
Copy link
Collaborator

Landed in 5d56097

RafaelGSS pushed a commit that referenced this pull request Jan 20, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #45241
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@RafaelGSS RafaelGSS mentioned this pull request Jan 20, 2023
juanarbol added a commit that referenced this pull request Jan 26, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #45241
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
juanarbol added a commit that referenced this pull request Jan 31, 2023
Signed-off-by: Juan José Arboleda <soyjuanarbol@gmail.com>
PR-URL: #45241
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@juanarbol juanarbol deleted the juan/coverage-text-decoder branch February 12, 2023 02:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

8 participants