Add automation for updating `libuv` dependency #45362

facutuesca · 2022-11-07T13:01:10Z

Description

Add a Github Action that checks for new versions of the libuv C library, and creates a PR to update it if a newer version than the one present in the repo is found.

Refs: nodejs/security-wg#828

Details

Currently, if one runs the script to update to version 1.44.2, the uv folder will end up with changes (even though Node's libuv version is also at 1.44.2):

bash tools/dep_updaters/update-libuv.sh 1.44.2
# (...script output....)

git status
# Changes not staged for commit:
#  (use "git add <file>..." to update what will be committed)
#  (use "git restore <file>..." to discard changes in working directory)
#        modified:   deps/uv/include/uv/win.h
#        modified:   deps/uv/src/win/poll.c

This is due to a change made when merging #42340. More specifically, see #42340 (comment). This accounts for the differences between Node's repo and upstream.

Since this seems to be a change that will be reverted in the next release (as per the comment), it should already be taken care of when the update-libuv.sh script is run for that next version.

cc: @lpinca

nodejs-github-bot · 2022-11-07T13:01:14Z

Review requested:

@nodejs/actions

lpinca · 2022-11-07T14:39:48Z

Sometimes manual changes to common.gypi and uv.gyp are needed but I guess we will notice this due to compilation failures. Another thing is how to add the changelog in the commit message.

facutuesca · 2022-11-07T14:55:44Z

Sometimes manual changes to common.gypi and uv.gyp are needed but I guess we will notice this due to compilation failures. Another thing is how to add the changelog in the commit message.

The idea for this script is to automate the copying of the source code to Node's repo, eliminating human errors in that step. Any extra changes (such as fixing the build files, or customizing the commit message) can be done on top of the branch created by the script, by the people reviewing/merging the PR.

My point is: automating the commit message to include the new version's changelog would add complexity, so maybe it could be a future improvement instead of adding it here.

lpinca · 2022-11-07T15:07:22Z

tools/update-libuv.sh

+cd "$WORKSPACE"
+
+echo "Fetching libuv source archive"
+curl -sL "https://api.github.com/repos/libuv/libuv/tarball/v$LIBUV_VERSION" | tar xzf -


https://dist.libuv.org/dist/v$LIBUV_VERSION/libuv-v$LIBUV_VERSION.tar.gz can also be used. I have no preference.

anonrig

lgtm

anonrig · 2022-11-10T15:20:17Z

@facutuesca Can you resolve the conflicts?

nodejs-github-bot · 2022-11-10T15:30:18Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47837/

facutuesca · 2022-11-10T16:12:15Z

@facutuesca Can you resolve the conflicts?

Fixed

nodejs-github-bot · 2022-11-10T21:16:41Z

CI: https://ci.nodejs.org/job/node-test-pull-request/47849/

tools/update-libuv.sh

aduh95

s/Node/Node.js/

node/doc/README.md

Lines 87 to 89 in 184af1c

    
           * Use _Node.js_ and not _Node_, _NodeJS_, or similar variants. 
        
             <!-- lint enable prohibited-strings remark-lint--> 
        
             * When referring to the executable, _`node`_ is acceptable.

Can you please wrap the lines in the markdown document to 80 chars?

tools/dep_updaters/README.md

tools/dep_updaters/update-libuv.sh

tools/dep_updaters/README.md

Add a Github Action that checks for new versions of the `libuv` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828

tools/dep_updaters/README.md

nodejs-github-bot · 2022-11-21T18:18:36Z

Landed in 59bb198

Add a Github Action that checks for new versions of the `libuv` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45362 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Add a Github Action that checks for new versions of the `libuv` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: nodejs#45362 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Add a Github Action that checks for new versions of the `libuv` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828 PR-URL: #45362 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

nodejs-github-bot added meta Issues and PRs related to the general management of the project. tools Issues and PRs related to the tools directory. labels Nov 7, 2022

lpinca approved these changes Nov 7, 2022

View reviewed changes

anonrig approved these changes Nov 10, 2022

View reviewed changes

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022

anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2022

This was referenced Nov 11, 2022

CI Reliability 2022-11-11 nodejs/reliability#425

Open

CI Reliability 2022-11-12 nodejs/reliability#426

Open

Trott force-pushed the main branch from 2d76238 to ca3ed36 Compare November 12, 2022 01:49

This was referenced Nov 13, 2022

CI Reliability 2022-11-13 nodejs/reliability#427

Open

CI Reliability 2022-11-14 nodejs/reliability#428

Open

CI Reliability 2022-11-15 nodejs/reliability#429

Open

mhdawson reviewed Nov 15, 2022

View reviewed changes

tools/update-libuv.sh Outdated Show resolved Hide resolved

gengjiawen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 17, 2022

aduh95 reviewed Nov 20, 2022

View reviewed changes

aduh95 removed the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 20, 2022

facutuesca added 2 commits November 21, 2022 10:11

tools: add automation for updating libuv dependency

a392194

Add a Github Action that checks for new versions of the `libuv` C library, and creates a PR to update it if a newer version than the one present in the repo is found. Refs: nodejs/security-wg#828

tools: move libuv update script to dep_updaters folder

6299a6a

facutuesca requested a review from aduh95 November 21, 2022 09:14

aduh95 reviewed Nov 21, 2022

View reviewed changes

tools/dep_updaters/README.md Outdated Show resolved Hide resolved

tools/dep_updaters/README.md Outdated Show resolved Hide resolved

tools: add README to dep_updaters folder

2de872c

facutuesca requested a review from aduh95 November 21, 2022 11:17

aduh95 approved these changes Nov 21, 2022

View reviewed changes

aduh95 added commit-queue Add this label to land a pull request using GitHub Actions. commit-queue-squash Add this label to instruct the Commit Queue to squash all the PR commits into the first one. labels Nov 21, 2022

nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 21, 2022

nodejs-github-bot merged commit 59bb198 into nodejs:main Nov 21, 2022

ruyadorno mentioned this pull request Nov 24, 2022

v19.2.0 proposal #45615

Merged

facutuesca deleted the libuv-ci-update branch December 5, 2022 09:48

facutuesca mentioned this pull request Dec 8, 2022

Automate updates of all dependencies nodejs/security-wg#828

Closed

23 tasks

danielleadams mentioned this pull request Dec 30, 2022

v18.13.0 release proposal #46025

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add automation for updating `libuv` dependency #45362

Add automation for updating `libuv` dependency #45362

facutuesca commented Nov 7, 2022 •

edited

nodejs-github-bot commented Nov 7, 2022

lpinca commented Nov 7, 2022

facutuesca commented Nov 7, 2022

lpinca Nov 7, 2022

anonrig left a comment

anonrig commented Nov 10, 2022

nodejs-github-bot commented Nov 10, 2022

facutuesca commented Nov 10, 2022

nodejs-github-bot commented Nov 10, 2022

aduh95 left a comment

nodejs-github-bot commented Nov 21, 2022

	* Use _Node.js_ and not _Node_, _NodeJS_, or similar variants.
	<!-- lint enable prohibited-strings remark-lint-->
	* When referring to the executable, _`node`_ is acceptable.

Add automation for updating libuv dependency #45362

Add automation for updating libuv dependency #45362

Conversation

facutuesca commented Nov 7, 2022 • edited

Description

Details

nodejs-github-bot commented Nov 7, 2022

lpinca commented Nov 7, 2022

facutuesca commented Nov 7, 2022

lpinca Nov 7, 2022

Choose a reason for hiding this comment

anonrig left a comment

Choose a reason for hiding this comment

anonrig commented Nov 10, 2022

nodejs-github-bot commented Nov 10, 2022

facutuesca commented Nov 10, 2022

nodejs-github-bot commented Nov 10, 2022

aduh95 left a comment

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 21, 2022

Add automation for updating `libuv` dependency #45362

Add automation for updating `libuv` dependency #45362

facutuesca commented Nov 7, 2022 •

edited