Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: simplify .eslintrc.js #45397

Merged
merged 1 commit into from Nov 12, 2022
Merged

tools: simplify .eslintrc.js #45397

merged 1 commit into from Nov 12, 2022

Conversation

Trott
Copy link
Member

@Trott Trott commented Nov 10, 2022

Remove explicit setting of configuration options in rules when those options are the defaults.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Nov 10, 2022
Remove explicit setting of configuration options in rules when those
options are the defaults.
@mscdex
Copy link
Contributor

mscdex commented Nov 10, 2022

Do we have any easy way of telling if the defaults change in the future?

@Trott
Copy link
Member Author

Trott commented Nov 10, 2022

Do we have any easy way of telling if the defaults change in the future?

Probably not. I suppose that could be a case for never using the defaults implicitly and spelling everything out in the config file, but I would prefer to go in the opposite direction of configuration file simplicity.

@Trott Trott added the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 12, 2022
@nodejs-github-bot nodejs-github-bot merged commit 9baf748 into nodejs:main Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 9baf748

ruyadorno pushed a commit that referenced this pull request Nov 21, 2022
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Nov 24, 2022
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Dec 30, 2022
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 3, 2023
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
danielleadams pushed a commit that referenced this pull request Jan 4, 2023
Remove explicit setting of configuration options in rules when those
options are the defaults.

PR-URL: #45397
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants