From 569de2553ecc59cdcb2543cb4b195c3bdfb5e06d Mon Sep 17 00:00:00 2001
From: Yagiz Nizipli <yagiz@nizipli.com>
Date: Thu, 10 Nov 2022 09:56:29 -0500
Subject: [PATCH] buffer: add asString static method

---
 doc/api/buffer.md                     | 37 +++++++++++++++++++
 lib/buffer.js                         | 11 ++++++
 src/node_buffer.cc                    | 32 +++++++++++++++++
 test/parallel/test-buffer-asstring.js | 52 +++++++++++++++++++++++++++
 4 files changed, 132 insertions(+)
 create mode 100644 test/parallel/test-buffer-asstring.js

diff --git a/doc/api/buffer.md b/doc/api/buffer.md
index 8b46553ec4941a..9bf4e57038b1ba 100644
--- a/doc/api/buffer.md
+++ b/doc/api/buffer.md
@@ -888,6 +888,43 @@ socket.on('readable', () => {
 
 A `TypeError` will be thrown if `size` is not a number.
 
+### Static method: `Buffer.asString(list[, encoding])`
+
+<!-- YAML
+added: REPLACEME
+-->
+
+* `list` {ArrayBufferView|ArrayBuffer|SharedArrayBuffer} Resource
+* `encoding` {string} If `string` is a string, this is its encoding.
+  **Default** `'utf8'`
+* Returns: {string} The encoded string representation of `list`
+
+```mjs
+import { Buffer } from 'node:buffer';
+
+const buf = new Uint8Array([
+  104, 101, 108, 108,
+  111, 32, 119, 111,
+  114, 108, 100,
+]);
+
+console.log(Buffer.asString(buf));
+// Prints: 'hello world'
+```
+
+```cjs
+const { Buffer } = require('node:buffer');
+
+const buf = new Uint8Array([
+  104, 101, 108, 108,
+  111, 32, 119, 111,
+  114, 108, 100,
+]);
+
+console.log(Buffer.asString(buf));
+// Prints: 'hello world'
+```
+
 ### Static method: `Buffer.byteLength(string[, encoding])`
 
 <!-- YAML
diff --git a/lib/buffer.js b/lib/buffer.js
index 7c0bbbc81c6398..b394777f37da34 100644
--- a/lib/buffer.js
+++ b/lib/buffer.js
@@ -52,6 +52,7 @@ const {
 } = primordials;
 
 const {
+  asString: _asString,
   byteLengthUtf8,
   compare: _compare,
   compareOffset,
@@ -538,6 +539,16 @@ Buffer.isEncoding = function isEncoding(encoding) {
 };
 Buffer[kIsEncodingSymbol] = Buffer.isEncoding;
 
+Buffer.asString = function asString(list, encoding = 'utf8') {
+  const normalizedEncoding = normalizeEncoding(encoding);
+  if (normalizedEncoding === undefined) {
+    validateString(encoding, 'encoding');
+    throw new ERR_UNKNOWN_ENCODING(encoding);
+  }
+
+  return _asString(list, encoding);
+};
+
 Buffer.concat = function concat(list, length) {
   validateArray(list, 'list');
 
diff --git a/src/node_buffer.cc b/src/node_buffer.cc
index eb8e541c68635d..6872535dc0c6bc 100644
--- a/src/node_buffer.cc
+++ b/src/node_buffer.cc
@@ -565,6 +565,36 @@ void StringSlice(const FunctionCallbackInfo<Value>& args) {
   args.GetReturnValue().Set(ret);
 }
 
+// Convert the input into a encoded string
+void AsString(const FunctionCallbackInfo<Value>& args) {
+  Environment* env = Environment::GetCurrent(args);  // list, encoding
+
+  if (!(args[0]->IsArrayBuffer() || args[0]->IsSharedArrayBuffer() ||
+        args[0]->IsArrayBufferView())) {
+    return node::THROW_ERR_INVALID_ARG_TYPE(
+        env->isolate(),
+        "The \"list\" argument must be an instance of SharedArrayBuffer, "
+        "ArrayBuffer or ArrayBufferView.");
+  }
+
+  CHECK(args[1]->IsString());
+
+  ArrayBufferViewContents<char> buffer(args[0]);
+  enum encoding enc = ParseEncoding(env->isolate(), args[1], UTF8);
+
+  if (buffer.length() == 0) return args.GetReturnValue().SetEmptyString();
+
+  Local<Value> error;
+  MaybeLocal<Value> maybe_ret = StringBytes::Encode(
+      env->isolate(), buffer.data(), buffer.length(), enc, &error);
+  Local<Value> ret;
+  if (!maybe_ret.ToLocal(&ret)) {
+    CHECK(!error.IsEmpty());
+    env->isolate()->ThrowException(error);
+    return;
+  }
+  args.GetReturnValue().Set(ret);
+}
 
 // bytesCopied = copy(buffer, target[, targetStart][, sourceStart][, sourceEnd])
 void Copy(const FunctionCallbackInfo<Value> &args) {
@@ -1282,6 +1312,7 @@ void Initialize(Local<Object> target,
 
   SetMethod(context, target, "setBufferPrototype", SetBufferPrototype);
   SetMethodNoSideEffect(context, target, "createFromString", CreateFromString);
+  SetMethodNoSideEffect(context, target, "asString", AsString);
 
   SetMethodNoSideEffect(context, target, "byteLengthUtf8", ByteLengthUtf8);
   SetMethod(context, target, "copy", Copy);
@@ -1339,6 +1370,7 @@ void Initialize(Local<Object> target,
 void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
   registry->Register(SetBufferPrototype);
   registry->Register(CreateFromString);
+  registry->Register(AsString);
 
   registry->Register(ByteLengthUtf8);
   registry->Register(Copy);
diff --git a/test/parallel/test-buffer-asstring.js b/test/parallel/test-buffer-asstring.js
new file mode 100644
index 00000000000000..c9bb221fc8863d
--- /dev/null
+++ b/test/parallel/test-buffer-asstring.js
@@ -0,0 +1,52 @@
+'use strict';
+
+const common = require('../common');
+const assert = require('assert');
+
+// utf8, ucs2, ascii, latin1, utf16le
+const encodings = ['utf8', 'utf-8', 'ucs2', 'ucs-2', 'ascii', 'latin1',
+                   'binary', 'utf16le', 'utf-16le'];
+
+[
+  {},
+  new Boolean(true),
+  { valueOf() { return null; } },
+  { valueOf() { return undefined; } },
+  { valueOf: null },
+  Object.create(null),
+  new Number(true),
+  Symbol(),
+  5n,
+  (one, two, three) => {},
+  undefined,
+  null,
+].forEach((input) => {
+  const errObj = {
+    code: 'ERR_INVALID_ARG_TYPE',
+    name: 'TypeError',
+  };
+  assert.throws(() => Buffer.asString(input), errObj);
+  assert.throws(() => Buffer.asString(input, 'hex'), errObj);
+});
+
+{
+  const value = Buffer.from('hello world');
+  encodings
+    .reduce((es, e) => es.concat(e, e.toUpperCase()), [])
+    .forEach((encoding) => {
+      assert.strictEqual(Buffer.asString(value, encoding), value.toString(encoding));
+    });
+}
+
+
+// Invalid encodings
+for (let i = 1; i < 10; i++) {
+  const encoding = String(i).repeat(i);
+  const error = common.expectsError({
+    code: 'ERR_UNKNOWN_ENCODING',
+    name: 'TypeError',
+    message: `Unknown encoding: ${encoding}`
+  });
+  assert.ok(!Buffer.isEncoding(encoding));
+  assert.throws(() => Buffer.asString([], encoding), error);
+}